Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP Support #8

Closed
deepaksp opened this issue May 19, 2016 · 14 comments
Closed

UWP Support #8

deepaksp opened this issue May 19, 2016 · 14 comments

Comments

@deepaksp
Copy link

any chance of adding uwp support ??

@SimonSimCity
Copy link
Owner

If you create a prototype of how an implementation could look like, I'd be glad to accept a pull-request or help you along in every way I can.

I have an windows environment at hand, but no sample application where I could test an implementation with.

@deepaksp
Copy link
Author

i have added BackgroundDownloader in my uwp project so i will try to fork n implement.If all good wiill create new pull request

@SimonSimCity
Copy link
Owner

@deepaksp What progress have you made until now? Is there anything I can assist you with?

@SimonSimCity
Copy link
Owner

Just found an interesting link to this topic: https://msdn.microsoft.com/en-us/windows/uwp/networking/background-transfers

@SimonSimCity
Copy link
Owner

@deepaksp, @Magic73, @adamashton, @cjw1115 I've now taken the time and wrote an implementation. Please check it out and leave some comments.

I met some restrictions concerning the destination of the downloaded files. Could you please check out this repo, read through the comments in the sample and help me finishing the implementation?

@Magic73
Copy link

Magic73 commented Mar 22, 2017

I'm going to do some test, and in case I will give to you some feedback/changes.

@muhaym
Copy link

muhaym commented May 21, 2017

Hi, I wish to contribute to the UWP part. Just to get started, can you please list out the issues and challenges faced by UWP project currently?

@SimonSimCity
Copy link
Owner

SimonSimCity commented May 21, 2017

@muhaym Thanks for your response. I personally haven't used this library on UWP for quite a while now, so I'd myself have to dive into the code and check it out once more. Feel free to just clone it an run the UWP project in the sample-folder.

I can just remember having some troubles to define the file-destination when creating the download. Here's a comment that I wrote because the system restricted me when I tried to save on a custom location: https://github.com/SimonSimCity/Xamarin-CrossDownloadManager/blob/develop/Sample/UWP/MainPage.xaml.cs#L33
I remember that I used a directory-picker and got an object back, but was (due to the current infrastructure of the library) only able to share a string as absolute path to the folder. When trying this, the plugin failed to write to this directory later, because the permissions to save to this folder were bound to the object. The reason here is, that I need the permission at any time, even if the app crashed and you open it. The user won't be happy if I ask for a directory every time he opens the app ...

Hope this helps getting started 😉

@muhaym
Copy link

muhaym commented May 21, 2017

@SimonSimCity Thanks. Looking forward to help with my current knowledge :)

@BtrJay
Copy link
Contributor

BtrJay commented Jul 17, 2017

Hi @SimonSimCity ,

Does UWP support the queued download? It seems iOS sample does work but not UWP.

After checking the UWP implementation, I've found that the file has never been added to a download queue for UWP.

Are there updates/fixes for this? I can open the pull request if there aren't

Kind Regards,

Jay

@SimonSimCity
Copy link
Owner

If there isn't any other feedback, I'm going to close this as a limited version for now and call it done.

@BtrJay
Copy link
Contributor

BtrJay commented Aug 14, 2017

Sure, it's done then

@SimonSimCity
Copy link
Owner

@SimonSimCity
Copy link
Owner

I've just released a new version where UWP is considered fully supported 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants