Type-definitions

[deser]

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

Need to add HTMLElement type on('move') handler for removed/added

[simonwep]

Excuse me? I'm not even providing ts-types for this package (at least not yet officially), do you mean this package?

[deser]

Sure, but who supports that package? Not you? Maybe it's time to convert to typescrtipt or have your own types?

[simonwep]

Huh, if you're using selectionjs with ts you should have recognized type-search and how they maintain types. And don't you see that this package doesn't even contain ts-files? Neither I'm mentioning ts-support or types anywhere in the readme.

Types by TypeSearch is made for packages who are not actively supporting types, so there's no reason to publish your js-package and "polyfilling" your own project with types.

I won't rewrite the code-base just for the sake of ts - maybe I'll add types sooner or later, is it that what you want? Native ts-support?

[deser]

I won't rewrite the code-base just for the sake of ts - maybe I'll add types sooner or later, is it that what you want? Native ts-support?

yeah :)

[simonwep]

@deser I've added and updated the type-definitions for this package. Typings for the move-event were already available so you might have just used a really old version.

In case I'm wrong, could you please tell me what's missing in here?

[deser]

Firstly, thanks a lot!

I think you need to change this at the top:

type ElementList = Element | readonly Element[] | NodeList | HTMLCollection | HTMLElement | HTMLElement[];

[simonwep]

Is that necessary? HTMLElement extends Element:

So theoretically that should be sufficient right?

type ElementList = Element | Element[] | HTMLCollection;

[deser]

No, Element doesn't have necessary props which HTMLElement has :) Please, just add and release new version :)

[deser]

@simonwep , so what? :)

[simonwep]

@deser If Element isn't sufficient - that should be enough right? Because you said that only HTMLElement contains the require properties:

type ElementList = NodeList  | HTMLCollection | HTMLElement | HTMLElement[];

Although NodeList can contain nodes which again are missing some of the properties :/

[deser]

HTMLElement is ok. I think you can do the changes and publish package :)

[simonwep]

Woah, no need to stress with publishing a new version. v1.7.0 now includes type-definitions :)

[deser]

Many thanks :)
Seems one more issue:

selected\added\removed - all of them are of ElementList type I think. I think most probably you need to add to Element | HTMLElement everywhere...

[simonwep]

These are always HTML elements so I can safely use HTMLElement.