Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send final modifications before removing an object from a bucket #159

Closed
beaucollins opened this issue Oct 15, 2014 · 3 comments · Fixed by #170
Closed

Send final modifications before removing an object from a bucket #159

beaucollins opened this issue Oct 15, 2014 · 3 comments · Fixed by #170

Comments

@beaucollins
Copy link
Contributor

An object should send all pending modifications before it is removed from the bucket.

@beaucollins
Copy link
Contributor Author

After some testing this appears to be the issue:

  1. Bucket object is modified and saved but not yet sent BucketObject.save()
  2. Bucket object is removed from bucket BucketObject.remove()
  3. Change processor kicks in to send the modification change
  4. Change processor tries to query for object to produce the diff but it no longer exists in the local persistent store due to step 2
  5. Modification attempt throws ChangeNotSentException
  6. Remove operation is sent

To resolve this we probably need to copy the data to diff during the modification operation so the storage system doesn't need to be queried. This will also solve #158.

@roundhill
Copy link
Contributor

There's a fair amount of crashes in the WordPress client for #158. Think you could knock this one out soon?

@roundhill
Copy link
Contributor

fair amount of crashes

And by fair, i mean 14 so far in 3.3 so not terrible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants