Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth with Token sequence isn't starting SPReachability #280

Closed
jleandroperez opened this issue May 28, 2014 · 2 comments
Closed

Auth with Token sequence isn't starting SPReachability #280

jleandroperez opened this issue May 28, 2014 · 2 comments
Assignees
@jleandroperez
Labels
bug
Milestone
v0.6.5

Comments

@jleandroperez
Copy link
Contributor

authenticateWithAppID:token: is initializing networking using startNetworkManagers method.

Instead, it should use startNetworking method, which will generate a reachability instance.
@jleandroperez jleandroperez added this to the v0.6.5 milestone May 28, 2014
@jleandroperez jleandroperez self-assigned this May 28, 2014
jleandroperez added a commit that referenced this issue May 28, 2014
@jleandroperez
Issue #280: Auth with Token sequence isn't starting SPReachability
8f25b51
@jphribovsek
Copy link

I believe this introduced a bug and that we can run in situations where startNetworkManagers is never called, this happens to us if we call authenticateWithAppID:token: at times other than app startup

@jleandroperez
Copy link
Contributor Author

@jphribovsek Please, take a look at #289. Should be fixed now.

Thank you!

@jleandroperez jleandroperez mentioned this issue Jun 30, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleandroperez jleandroperez

Labels
bug
Projects
None yet
Milestone
v0.6.5
Development

No branches or pull requests
2 participants
@jphribovsek @jleandroperez