-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python versions < 2.6 #3
Comments
OK, obvs the issue is that I am using a version of Python < 2.6, which is when the json library was added. I have been keeping my python at 2.5.x because that's the default for app engine. I think it would be great to support versions of Python prior to 2.6, but recommend that for now at the very least your documentation note the requirement of Python 2.6. |
Also discovered another 2.6+ compatibility problem: the timeout attribute in urllib2.urlopen. Have worked around it in my fork. Can send you a pull request if you want to support < 2.6. |
Yeah, could you send through a pull request bbn. Curious as to the approach you used for the missing timeout in urllib2.urlopen. Gotcha re the json import. I'll add a conditional import which pulls in simplejson if the builtin json isn't available. |
Actually, can see the change here: bbn@ff7e90f -- Nice, I'll update our version with this approach. |
Thanks bbn, I've incorporated these changes. Rather than including simplejson in our repo, I've made it a conditional dependency in setup.py for python clients < 2.6 |
glad if I helped! |
Using Python 2.5.6 on a mac laptop. Trying to import the library but it fails trying to import json library. I can add one easily enough, but I imagine you want this to work out of the box as much as possible!
The text was updated successfully, but these errors were encountered: