Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPAuthenticator: enhance needsAuthentication helper #434

Closed
jleandroperez opened this issue Jan 16, 2015 · 0 comments · Fixed by #444
Closed

SPAuthenticator: enhance needsAuthentication helper #434

jleandroperez opened this issue Jan 16, 2015 · 0 comments · Fixed by #444
Labels
enhancement
Milestone
v0.7.8

Comments

@jleandroperez
Copy link
Contributor

We've been pointed out that there is no way to determine how's the library going to react to a authenticateWithAppID: call (will it display the loginViewController? or it will just open the websocket?).

This might be required to render, perhaps, a different label on the host app's settings UI.

Let's update SPAuthenticator needsAuthentication helper, so the appID is actually a parameter.
@jleandroperez jleandroperez added this to the v0.7.7 milestone Jan 16, 2015
@jleandroperez jleandroperez modified the milestones: v0.7.7, v0.7.8 Feb 4, 2015
@jleandroperez jleandroperez mentioned this issue Feb 5, 2015
Merged
jleandroperez added a commit that referenced this issue Feb 5, 2015
@jleandroperez
Merge pull request #444 from /issues/434-updates-neeed-authentication…
5fb3e17 
…-helper

Updates neeedAuthentication Helper
@jleandroperez jleandroperez mentioned this issue Feb 6, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.7.8
Development

Successfully merging a pull request may close this issue.

Updates neeedAuthentication Helper Simperium/simperium-ios
1 participant
@jleandroperez