Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podspec: Include SSKeychain as a dependency, rather than including the source #452

Closed
danielr opened this issue Feb 25, 2015 · 2 comments
Closed
Milestone

Comments

@danielr
Copy link

danielr commented Feb 25, 2015

I've just run into a duplicate symbols issue after adding SSKeychain to my project (which also uses Simperium) and then I noticed that you include an (unprefixed!) version of this library in your source... Having a look at your Podfile, you seem to include most of your external stuff as Cocoapods dependencies (most notably JRSwizzle and SocketRocket) - why not do the same for SSKeychain?

But apart from that, if you also distribute your lib outside of Cocoapods, you should really think about prefixing your external dependencies (or remove them and require users to manually install them).

@jleandroperez jleandroperez added this to the v0.7.9 milestone Feb 25, 2015
@jleandroperez
Copy link
Contributor

@danielr you're indeed right sir. We'll be soon updating the way we handle dependencies.

Thanks for the suggestion!

jleandroperez added a commit that referenced this issue Mar 19, 2015
jleandroperez added a commit that referenced this issue Mar 19, 2015
jleandroperez added a commit that referenced this issue Mar 19, 2015
@jleandroperez
Copy link
Contributor

@danielr Dependencies prefixed, except for DiffMatchPatch, which will remain pristine, for the time being.

We'll be releasing a new Cocoapods version shortly, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants