Simperium: Committing pending CoreData OP's before quitting #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @roundhill (thanks Dan!) |
|
|
roundhill
added a commit
that referenced
this pull request
Apr 24, 2015
Simperium: Committing pending CoreData OP's before quitting
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the OSX Helper applicationShouldTerminate, so that it makes sure that any pending CoreData OP gets processed, before the termination message is acknowledged.
Details:
This is a required patch to address a Simplenote issue, in which the users may loose new changes, if they close the app very quickly right afterwards.