Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR wires TrustKit into Simperium: we're replacing SocketRocket former pinning mechanism.
Testing scenarios below.
Needs Review: @roundhill @astralbodies
Thanks in advance!!!
Scenario: Pinning Disabled!
pod 'Simperium', :path => '../simperium-ios/'
Verify that no TrustKit legend shows up in the console. Sync'ing should work seamlessly.
Scenario: Pinning Enabled
SPAppDelegate.m
(methodsetupSimperium
) and add this line:[_simperium setCertificatePinningEnabled:YES]
Verify the console logs. TrustKit should get initialized, and sync'ing should be working fine.
Verify Signatures!
openssl s_client -showcerts -host api.simperium.com -port 443
*.simperium.com
into a.pem
file../External/TrustKit/get_pin_from_certificate.py certificate.pem
SPEnvironment.m
matches