SPWebSocketChannel: Setting lastChangeSignature on empty buckets #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
In this PR we're setting an empty string, as the lastChangeSignature, whenever the indexed bucket is actually empty.
This will prevent constant reindex on empty buckets.
Testing:
samples
folder)SIMPERIUM_APP_ID
andSIMPERIUM_API_KEY
keys with a fresh appVerify that after relaunching, the console won't show a reindex cycle anymore.
Needs review: @roundhill
Thanks in advance sir!