Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPWebSocketChannel: Setting lastChangeSignature on empty buckets #572

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

jleandroperez
Copy link
Contributor

Details:

In this PR we're setting an empty string, as the lastChangeSignature, whenever the indexed bucket is actually empty.

This will prevent constant reindex on empty buckets.

Testing:

  1. Open the SimpletodoFinal app (samples folder)
  2. Replace the SIMPERIUM_APP_ID and SIMPERIUM_API_KEY keys with a fresh app
  3. Add, in this spot, the following snippet:
    self.simperium.verboseLoggingEnabled = true;
  1. Launch the demo app and signup
  2. Restart the app

Verify that after relaunching, the console won't show a reindex cycle anymore.

Needs review: @roundhill
Thanks in advance sir!

@jleandroperez jleandroperez added this to the 0.8.19 milestone Nov 30, 2017
@jleandroperez jleandroperez self-assigned this Nov 30, 2017
@roundhill
Copy link
Contributor

LGTM :shipit:

@jleandroperez
Copy link
Contributor Author

Thanks for the review Dan!

@jleandroperez jleandroperez merged commit 02c9681 into develop Nov 30, 2017
@jleandroperez jleandroperez modified the milestones: 0.8.19, 0.8.20 Nov 30, 2017
@jleandroperez jleandroperez deleted the issue/preventing-reindex-on-empty-buckets branch June 3, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants