Login: Safe Insets #576
Merged
Login: Safe Insets #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bummytime
approved these changes
Jun 17, 2019
There was a problem hiding this comment.
This looks good @jleandroperez. I tested the heck out of the simplenote PR and all of the insets looked great across many devices and iOS versions. Let's 
this and cut a new Simperium pod (0.8.22).
Nice work!!
|
Thank you Matt!! Shipping Simperium 0.8.22 now now now!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
In this PR we're patching up our Authentication UI, so that it reacts and adapts properly to a variety of scenarios.
Our main goal is to have a proper top inset in devices with notch (X / X Max / Xs / Xs Max).
For proper testing steps, please refer to this Simplenote PR.
Thank you sir!
cc @bummytime