AuthenticationInterface Protocol #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleandroperez
changed the title
bummytime
approved these changes
Aug 5, 2019
There was a problem hiding this comment.
@jleandroperez I like the use of SPAuthenticationInterface in this PR!
Smoke tested the auth flows on iOS 10-13:
✅ Verify the Authentication UI shows up in portrait, even when the app launches with the simulator in landscape
✅ Verify rotations in the Onboarding and Authentication UI(s) are disabled
✅ iPad Onboarding and Authentication UI(s) flows did rotate (as expected)
Also, everything built fine on XCode 10 and 11 beta 5. 
|
Thanks for reviewing this Bummy!! 🔥 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
This PR implements SPAuthenticationInterface, which allows us to further customize the Authentication UI.
Plus a new public property, to be called *authenticationShouldBeEmbeddedInNavigationController, allows us to explicitly set if we want the SPAuthenticationInterface to live within a navigation stack.
Ref.: Simplenote's Nü Onboarding
cc @bummytime
Thanks in advance sir!!
Testing:
In order to test this PR, please, checkout this Simplenote PR.