Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloading Inconsistent Entities #585

Merged
merged 7 commits into from
Dec 19, 2019

Conversation

jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Dec 17, 2019

Details:

In this PR we're adding an error handling mechanism, capable of detecting Ghost(s) in inconsistent states, and triggering a full entity re-download.

cc @bummytime
cc @dmsnell

Closes #584

Testing:

  1. Check out Simplenote iOS
  2. Map Simperium's dependency to commit bbcbc91 (this branch, latest!)
  3. Comment out DiffMatchPach.m L1510 thru L1528
  4. Clean + Rebuild
  5. Log into your account
  6. Add a new note
  7. Insert the following emojis: ☺️🖖🏿
  8. Insert the following emoji in between: 😃
  • Verify Simplenote does not crash
  • Verify that (after a second) you end up with ☺️😃(null)🖖🏿 onscreen

Note:

@jleandroperez jleandroperez added this to the 0.8.26 milestone Dec 17, 2019
@jleandroperez jleandroperez self-assigned this Dec 17, 2019
Copy link
Member

@bummytime bummytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jleandroperez Ok I tested this pretty well.

✅ code
✅ unit tests

I also tested this branch against the release/4.14.2 hotfix branch for Simplenote:

  1. Fetched, built, installed tags/4.13 and ran + added the spock note (crashed!)
  2. Fetched, built, installed release/4.14.2 and ran it (crashes on startup)
  3. Fetched this branch against release/4.14.2 and ran it (no crash):

Screen Shot 2019-12-19 at 9 20 52 AM

:shipit: !!

@jleandroperez
Copy link
Contributor Author

Thank you for testing this one Bummy!!

@jleandroperez jleandroperez merged commit 55058dd into develop Dec 19, 2019
@jleandroperez jleandroperez deleted the issue/584-reloading-inconsistent-entities branch December 19, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSJSONSerialization Crash
2 participants