Fixing AuthTextField UI Glitch #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshurakov
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
Checked it via Automattic/simplenote-macos#900 and it works great!
CI is failed for some reason 🤔
|
I couldn't trigger another CI pass I'm afraid (but builds + tests pass locally). Thank you Evgeny!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
In this PR we're updating the mechanism used by SPAuthenticationTextField to determine its first responder state.
Previous mechanism failed in specific scenarios, causing the "Active State" to fall out of sync.
Testing
Please refer to this Simplenote PR for testing steps.