Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devel #118

Merged
merged 1 commit into from Nov 16, 2022
Merged

Devel #118

merged 1 commit into from Nov 16, 2022

Conversation

jcarpent
Copy link
Member

  • CI: allow macOS Debug to fail -> checking for memory alloc
  • currently we check for runtime memory allocations in this one specific pipeline
  • we still observe a few during the dense solve, but we dont want to PRs to be marked as failed, it's a way to keep track of mem allocs but no critical failure
  • update naming to use underscore

  • move continue-on-error from job to specific step

  • exclude macos debug with continue-on-error True

  • due to our include structure we have to specifically exclude this cfg otherwise we have two macOS Debug c++17
  • debug: deactivate linux/windows pipelines to check

  • fix continue-on-error

  • enable back all pipelines

* CI: allow macOS Debug to fail -> checking for memory alloc

- currently we check for runtime memory allocations in this one specific pipeline
- we still observe a few during the dense solve, but we dont want to PRs to be marked as failed, it's a way to keep track of mem allocs but no critical failure

* update naming to use underscore

* move continue-on-error from job to specific step

* exclude macos debug with continue-on-error True

- due to our include structure we have to specifically exclude this cfg otherwise we have two macOS Debug c++17

* debug: deactivate linux/windows pipelines to check

* fix continue-on-error

* enable back all pipelines
@jcarpent jcarpent merged commit b366929 into main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants