Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing includes #21

Merged
merged 1 commit into from Aug 29, 2022
Merged

add missing includes #21

merged 1 commit into from Aug 29, 2022

Conversation

nim65s
Copy link
Member

@nim65s nim65s commented Aug 29, 2022

Hi,

On a standard ubuntu 20.04, with gcc 9.4 and eigen 3.3.7, eigen has a std::cerr somewhere and compilation raise some occurences of :

In file included from /usr/include/eigen3/unsupported/Eigen/IterativeSolvers:29,
                 from ../include/proxsuite/proxqp/sparse/views.hpp:21,
                 from ../include/proxsuite/proxqp/sparse/solver.hpp:20,
                 from ../include/proxsuite/proxqp/sparse/wrapper.hpp:12,
                 from ../test/src/sparse_qp.cpp:4:
/usr/include/eigen3/unsupported/Eigen/src/IterativeSolvers/ConstrainedConjGrad.h: In function ‘void Eigen::internal::constrained_cg(const TMatrix&, const CMatrix&, VectorX&, const VectorB&, const VectorF&, Eigen::IterationController&)’:
/usr/include/eigen3/unsupported/Eigen/src/IterativeSolvers/ConstrainedConjGrad.h:162:51: error: ‘cerr’ is not a member of ‘std’
  162 |     if (iter.noiseLevel() > 0 && transition) std::cerr << "CCG: transition\n";
      |                                                   ^~~~
/usr/include/eigen3/unsupported/Eigen/src/IterativeSolvers/ConstrainedConjGrad.h:30:1: note: ‘std::cerr’ is defined in header ‘<iostream>’; did you forget to ‘#include <iostream>’?
   29 | #include "../../../../Eigen/src/Core/util/NonMPL2.h"
  +++ |+#include <iostream>
   30 |

Here is a quick fix, but this is not super satisfying…

PS: I pushed to simple-robotics/devel by mistake, and reverted back a few seconds after that, sorry for the mess :(

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2022

CLA assistant check
All committers have signed the CLA.

@jcarpent jcarpent merged commit f9c8679 into Simple-Robotics:devel Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants