Templating power iteration algorithm by matrix storage order #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi ! This project doesn't usually accept pull requests on the main branch. |
fabinsch
force-pushed
the
qll/test-colmajor
branch
2 times, most recently
from
deb7c14
to
cbc5297
Compare
jcarpent
force-pushed
the
qll/test-colmajor
branch
from
cbc5297
to
c5f1081
Compare
jcarpent
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The power_iteration helper is currently expecting matrices stored in RowMajor as inputs. A memory allocation is performed every time the user provides a matrix stored in ColMajor. This PR aims at extending the current API to handle ColMajor matrices without making any memory allocation.