Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert the Running/Walking States #485

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DEATHB4DEFEAT
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT commented Jun 24, 2024

Description

Ports Simple-Station/Parkstation-Friendly-Chainsaw#39

A change made to encourage people to stop and smell the roses, instead of sprinting everywhere trying to get shit done.
This goes well with #486, so people don't actually have to rush places to try to get things done before the shift ends fatally.
It's weird anyway how we're all constantly sprinting everywhere and have to very actively choose not to (and why would you?).
Increases the default speeds so that walking isn't painfully slow and sprinting feels more like sprinting in combination with the active choice to sprint.

Someone needs to PR changing the default sprint or examine buttons, so people can fight and sprint with this change.
(A lot of other default keybinds suck or conflict too and need to change)

Changelog

🆑

  • tweak: The station's crew hivemind has decided to slow down their movement and enjoy The Park instead of sprinting everywhere

Simple-Station/Parkstation#193

🆑
- tweak: The station's crew hivemind has decided to slow down their
movement and enjoy The Park instead of sprinting everywhere
@DEATHB4DEFEAT DEATHB4DEFEAT added Size: 4-Small For small issues/PRs Priority: 3-Medium Needs to be resolved at some point Type: Port Brings something to here from another codebase labels Jun 24, 2024
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Jun 24, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Jun 24, 2024
@FoxxoTrystan
Copy link
Contributor

Im not a fan of this change, i like the shift to slow down because else mostly nearly everyone is going to hold shift to just walk, and that just may be annoying.

@DEATHB4DEFEAT
Copy link
Member Author

Im not a fan of this change, i like the shift to slow down because else mostly nearly everyone is going to hold shift to just walk, and that just may be annoying.

Use toggle sprint or slow down and enjoy The Park.

@DEATHB4DEFEAT DEATHB4DEFEAT removed their assignment Jun 24, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern here is that there should be a note somewhere of how to reverse this change; or maybe making this a CVAR although I assume since this isn't a CVAR it's hard to do.

Primarily for uh; if someone downloads EE for the first time with the intention to host, and they want to revert this change they'll have to go on the Github or Discord and dig around instead of being able to neatly toggle it or easily find it.

Something like that; just thoughts.

@DEATHB4DEFEAT
Copy link
Member Author

My main concern here is that there should be a note somewhere of how to reverse this change; or maybe making this a CVAR although I assume since this isn't a CVAR it's hard to do.

Not a very easy thing to CVar, but probably doable.
If you want to reverse this change, revert this PR.

@DangerRevolution
Copy link
Contributor

DangerRevolution commented Jun 24, 2024

My main concern here is that there should be a note somewhere of how to reverse this change; or maybe making this a CVAR although I assume since this isn't a CVAR it's hard to do.

Not a very easy thing to CVar, but probably doable. If you want to reverse this change, revert this PR.

A comment in the CVar file will be more than enough :) Similar to the trade station

Leave making it a CVAR as a TODO

@DEATHB4DEFEAT
Copy link
Member Author

Added a description explaining rationale.

@@ -113,7 +113,7 @@ ui-options-function-move-up = Move Up
ui-options-function-move-left = Move Left
ui-options-function-move-down = Move Down
ui-options-function-move-right = Move Right
ui-options-function-walk = Walk
ui-options-function-walk = Run

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misleading fluent key

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know why this is the engine. I can't change this.

image

image

Copy link

@misandrie misandrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is directly messing with input code - should be either behind a CVAR with the default being false or toggleable by the user.
Game is made to be fast-paced, indicative by multiple (emergent) mechanics, like slipping speed or reflect thresholds.

@DangerRevolution
Copy link
Contributor

This is directly messing with input code - should be either behind a CVAR with the default being false or toggleable by the user. Game is made to be fast-paced, indicative by multiple (emergent) mechanics, like slipping speed or reflect thresholds.

Above is very true; but default should be set to true

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jun 25, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Jun 25, 2024
@DangerRevolution DangerRevolution marked this pull request as draft July 4, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this Type: Port Brings something to here from another codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants