Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/Run Scripts from Parkstation #6

Merged
merged 5 commits into from
May 18, 2024

Conversation

DEATHB4DEFEAT
Copy link
Member

Description

Adds several scripts to make building and running the projects easier outside of an IDE.

@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Port Scripts from Parkstation [PORT] Scripts from Parkstation Mar 17, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT added Priority: 2-High Needs to be resolved as soon as possible Size: 4-Small For small issues/PRs Type: Port Brings something to here from another codebase labels Mar 17, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title [PORT] Scripts from Parkstation Build/Run Scripts from Parkstation Mar 19, 2024
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just finished testing the entire .bat side of this PR, but since I don't have any way of running shell scripts on my monster rig(and I'm not going to go install Linux or a VM just to test this PR), I'm giving my approval for that half of the PR. Psprite wants to verify that the Shell half of these scripts works as advertised, they can be my guest. Otherwise I'll leave it up to them to merge this. This has my approval so far.

@DEATHB4DEFEAT
Copy link
Member Author

I tested the batch scripts in cmd and the shell scripts in git bash, Linux users may need to add the executable permission themselves though.

Copy link
Contributor

@stellar-novas stellar-novas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux script permissions are wrong, the owner at least should have execute, so 744/rwxr--r--

@stellar-novas
Copy link
Contributor

As for the scripts themselves, yeah good though it might be nice to have a Tools one, as Danger said.

@DEATHB4DEFEAT
Copy link
Member Author

I'll set the permissions and add a Tools build when I get time

@DEATHB4DEFEAT DEATHB4DEFEAT marked this pull request as draft March 21, 2024 02:22
@DEATHB4DEFEAT DEATHB4DEFEAT marked this pull request as ready for review May 18, 2024 21:02
@github-actions github-actions bot added the Status: Needs Review Someone please review this label May 18, 2024
@DEATHB4DEFEAT
Copy link
Member Author

DEATHB4DEFEAT commented May 18, 2024

I have returned.

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd merge but looks like you're still working on it :)

@DEATHB4DEFEAT DEATHB4DEFEAT merged commit 790fe7d into Simple-Station:master May 18, 2024
6 of 9 checks passed
@DEATHB4DEFEAT DEATHB4DEFEAT deleted the scripts branch May 18, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2-High Needs to be resolved as soon as possible Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this Type: Port Brings something to here from another codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants