Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: User reviews #48

Merged
merged 8 commits into from
Aug 5, 2022

Commits on Jul 16, 2022

  1. Configuration menu
    Copy the full SHA
    e8a9044 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Redesigned endpoints responsible for reviews.

    Implemented updating and deleting reviews.
    Eukon05 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    b7fe4fe View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2022

  1. Configuration menu
    Copy the full SHA
    c456ac0 View commit details
    Browse the repository at this point in the history
  2. Changed parameter type in review related methods from Long to long, w…

    …here possible.
    
    Fixed antMatchers related to reviews in WebSecurityConfig.
    Eukon05 committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    fe076f1 View commit details
    Browse the repository at this point in the history
  3. Changed parameter type from Long to long in UserService methods respo…

    …nsible for retrieving users from the DB
    Eukon05 committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    3e73e45 View commit details
    Browse the repository at this point in the history
  4. - Renamed a method in ReviewController.

    - Added a "@Valid" annotation to UpdateReviewDTO parameter in updateReview method in ReviewController.
    - Added a new constructor to UserNotFoundException to allow for handling situations in which te user is being retrieved by username (so that we don't have to rely on Spring Security exceptions where not necessary).
    - Moved review content parsing from ReviewService methods to a setter in the Review object
    Eukon05 committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    501a7c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. Review:

    - Changed id variable type to a primitive type
    - Added a maximum size of the content variable (400)
    - Added @NotNull constraints on user objects
    
    DTOs:
    - Modified constraint validation on CreateReviewDTO and UpdateReviewDTO to account for changes related to the Review object
    
    Exceptions:
    - Modified exception message variable names
    
    Mappers:
    - Removed custom entity and dto mappers, to rely on MapStruct instead
    
    ReviewServiceImpl:
    - Modified createReview method to account for changes related to the Review object
    - Modified methods responsible for retrieving reviews to account for the MapStruct change
    Eukon05 committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    67d9932 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into feat-tutor-reviews

    # Conflicts:
    #	pom.xml
    #	src/main/java/pl/simpleascoding/tutoringplatform/api/ReviewController.java
    Eukon05 committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    0ae4405 View commit details
    Browse the repository at this point in the history