Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Github actions #88

Merged
merged 39 commits into from
Dec 13, 2020
Merged

Migrate to Github actions #88

merged 39 commits into from
Dec 13, 2020

Conversation

cmodijk
Copy link
Member

@cmodijk cmodijk commented Dec 8, 2020

What is inside this pull request

  • I moved all the packages to the packages/ folder to allow symplify/monorepo-builder to test all the packages with there own unit tests and requirements
  • I made sure al the requirements between de packages are in sync
  • I removed the .travis.yml files but we still need to remove the integrations hooks
  • For testing i added the minimum-stability and prefer-stable settings
  • I changed the tests from Symfony 4.4.* and 5.0.* to 4.4.* and 5.2.*
  • Changed Doctrine\Common\Persistence\ManagerRegistry to Doctrine\Persistence\ManagerRegistry
  • Fixed the unit tests for rabbitmq-bundle-bridge
  • Added PHP 8.0 as a matrix
  • Fixed the first PHP 8.0 tests

TODO

@cmodijk cmodijk changed the title Migrate to Github actions WIP: Migrate to Github actions Dec 8, 2020
@ruudk
Copy link
Contributor

ruudk commented Dec 8, 2020

The authors section is removed and that's fixed by deprecated-packages/symplify#2605. Waiting for that to be merged and tagged before I can continue with LongRunning.

@cmodijk
Copy link
Member Author

cmodijk commented Dec 8, 2020

Yeah i removed it manually i first want the build to work before using the merge

@cmodijk cmodijk force-pushed the github-actions branch 24 times, most recently from 8ba127a to 23c5cb5 Compare December 9, 2020 02:28
Copy link
Contributor

@ruudk ruudk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @cmodijk 🙌

Comment on lines 39 to 41
composer-lowest:
- 'no'
- 'yes'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the size of the matrix, maybe we should just always use lowest?

Copy link
Member Author

@cmodijk cmodijk Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also always test agains the latest versions. I only want to test on the lowest once in PHP 7.4 but i still need to check how to do this.

Copy link
Member Author

@cmodijk cmodijk Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the exclude to only run once per package

.github/workflows/tests.yaml Outdated Show resolved Hide resolved
@cmodijk cmodijk merged commit 4597a2f into master Dec 13, 2020
@cmodijk cmodijk deleted the github-actions branch December 13, 2020 09:16
@cmodijk
Copy link
Member Author

cmodijk commented Dec 13, 2020

@ruudk I rebased this on top op the latest master so that is why the review got removed. I went along and still merged this so it is in master right now.

@holtkamp
Copy link
Contributor

holtkamp commented Jan 18, 2021

Would it be possible to tag a release which supports PHP 8?

For example, simplebus/asynchronous dev-master allows it, but there is no way to install it...

Additionally, https://github.com/Ocramius/ProxyManager/releases/tag/2.11.0 now supports PHP 8 so no more fork is required...

@cmodijk
Copy link
Member Author

cmodijk commented Jan 18, 2021

I still want to finish #106 but i currently don't have a lot of time for this.

@ruudk Have you already tested the latest version on PHP 8? If so then i don't see a problem in tagging the first version.

@ruudk
Copy link
Contributor

ruudk commented Jan 19, 2021

Unfortunately we're not on PHP 8 yet because we're blocked by NewRelic :(.

I don't think we have to wait for #106 as that's just nice to have.

@holtkamp Are you able to test current dev-master?

@holtkamp
Copy link
Contributor

holtkamp commented Jan 19, 2021

Unfortunately we're not on PHP 8 yet because we're blocked by NewRelic :(.

Same here 👀 ...

@holtkamp Are you able to test current dev-master?

Yes, been using it in production on PHP 7.4.13 for some days without encountering any issues using the following composer.json configuration:

    "simple-bus/bernard-bundle-bridge": "dev-allow-php-8",
    "simple-bus/asynchronous": "dev-master as 3.1.1",
    "simple-bus/asynchronous-bundle": "dev-master as 3.2.1",
    "simple-bus/message-bus": "dev-master as 3.1.1",
    "simple-bus/serialization": "dev-master as 3.1.1",

Locally it is running on PHP 8.0.1 without encountering any issues...

@ruudk
Copy link
Contributor

ruudk commented Jan 19, 2021

Sounds good :) @cmodijk Could you take a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants