-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Github actions #88
Conversation
The |
Yeah i removed it manually i first want the build to work before using the merge |
8ba127a
to
23c5cb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @cmodijk 🙌
.github/workflows/tests.yaml
Outdated
composer-lowest: | ||
- 'no' | ||
- 'yes' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the size of the matrix, maybe we should just always use lowest
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also always test agains the latest versions. I only want to test on the lowest
once in PHP 7.4
but i still need to check how to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the exclude to only run once per package
6bb4a47
to
5fafe18
Compare
Symfony 5.0 is end of life. See https://symfony.com/releases
To support PHP 8
This reverts commit c399bdc.
ac8e838
to
9180916
Compare
@ruudk I rebased this on top op the latest |
Would it be possible to tag a release which supports PHP 8? For example, simplebus/asynchronous dev-master allows it, but there is no way to install it... Additionally, https://github.com/Ocramius/ProxyManager/releases/tag/2.11.0 now supports PHP 8 so no more fork is required... |
Same here 👀 ...
Yes, been using it in production on PHP
Locally it is running on PHP |
Sounds good :) @cmodijk Could you take a new release? |
What is inside this pull request
packages/
folder to allowsymplify/monorepo-builder
to test all the packages with there own unit tests and requirements.travis.yml
files but we still need to remove the integrations hooksminimum-stability
andprefer-stable
settings4.4.*
and5.0.*
to4.4.*
and5.2.*
Doctrine\Common\Persistence\ManagerRegistry
toDoctrine\Persistence\ManagerRegistry
rabbitmq-bundle-bridge
8.0
as a matrix8.0
testsTODO
--ignore-platform-req php
is only used in the8.0
version (for now)prefer-lowest
test caserabbitmq-bundle-bridge
on PHP8.0
PHP 8: Required parameter $io follows optional parameter $vhost php-amqplib/php-amqplib#846
REMOVE_PROXY_BRIDGE
test case or check why it was neededauthors
,type
andconflicting
deprecated-packages/symplify#2605)