allow pass ArrayAccess objects to CallableMap

.gitignore

@@ -3,3 +3,4 @@ phpunit.xml
 .couscous/
 composer.lock
 /build/
+.idea

src/CallableResolver/CallableMap.php

@@ -2,6 +2,7 @@
 
 namespace SimpleBus\Message\CallableResolver;
 
+use SimpleBus\Message\CallableResolver\Exception\CouldNotResolveCallable;
 use SimpleBus\Message\CallableResolver\Exception\UndefinedCallable;
 
 class CallableMap
@@ -10,37 +11,42 @@ class CallableMap
      * @var array
      */
     private $callablesByName;
-
+    
     /**
      * @var CallableResolver
      */
     private $callableResolver;
-
+    
     public function __construct(
-        array $callablesByName,
+        $callablesByName,
         CallableResolver $callableResolver
     ) {
-        $this->callablesByName = $callablesByName;
+        if(!is_array($callablesByName) && !is_a($callablesByName, '\ArrayAccess')) {
+            throw new CouldNotResolveCallable("Unexpected callables map - pass array or object implementing ArrayAccess");
+        }
+
+        $this->callablesByName  = $callablesByName;
         $this->callableResolver = $callableResolver;
     }
-
+    
     /**
      * @param string $name
+     *
      * @return callable
      */
     public function get($name)
     {
-        if (!array_key_exists($name, $this->callablesByName)) {
+        if(!isset($this->callablesByName[ $name ])) {
             throw new UndefinedCallable(
                 sprintf(
                     'Could not find a callable for name "%s"',
                     $name
                 )
             );
         }
-
-        $callable = $this->callablesByName[$name];
-
+        
+        $callable = $this->callablesByName[ $name ];
+        
         return $this->callableResolver->resolve($callable);
     }
 }

tests/Handler/CallableMap/CallableMapTest.php

@@ -0,0 +1,65 @@
+<?php
+namespace SimpleBus\Message\Tests\Handler\CallableMap;
+
+use SimpleBus\Message\CallableResolver\CallableMap;
+use SimpleBus\Message\CallableResolver\ServiceLocatorAwareCallableResolver;
+use SimpleBus\Message\Tests\Handler\CallableMap\Fixtures\CommandToHandlerMapper;
+
+class CallableMapTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @test
+     */
+    function it_accepts_ArrayAccess_interface_as_a_map()
+    {
+        $commandHandlerMap = new CallableMap(
+            new CommandToHandlerMapper(),
+            new ServiceLocatorAwareCallableResolver($this->sampleServiceLocator())
+        );
+
+        $command_fqcn          = 'SimpleBus\Message\Tests\Handler\CallableMap\Fixtures\DummyCommand';
+        $expected_handler_fqcn = 'SimpleBus\Message\Tests\Handler\CallableMap\Fixtures\DummyCommandHandler';
+
+        $this->assertEquals($expected_handler_fqcn, $commandHandlerMap->get($command_fqcn)[0]);
+    }
+
+    /**
+     * @test
+     */
+    function it_accepts_array_as_a_map()
+    {
+        $command_fqcn = 'SimpleBus\Message\Tests\Handler\CallableMap\Fixtures\DummyCommand';
+        $handler_fqcn = 'SimpleBus\Message\Tests\Handler\CallableMap\Fixtures\DummyCommandHandler';
+
+        $commandHandlerMap = new CallableMap(
+            [
+                $command_fqcn => $handler_fqcn,
+            ],
+            new ServiceLocatorAwareCallableResolver($this->sampleServiceLocator())
+        );
+
+        $this->assertEquals($handler_fqcn, $commandHandlerMap->get($command_fqcn)[0]);
+    }
+
+    /**
+     * @test
+     */
+    function it_wont_accept_wrong_types()
+    {
+        $this->setExpectedException('SimpleBus\Message\CallableResolver\Exception\CouldNotResolveCallable');
+
+        new CallableMap(
+            "wrong type",
+            new ServiceLocatorAwareCallableResolver($this->sampleServiceLocator())
+        );
+
+    }
+
+
+    private function sampleServiceLocator()
+    {
+        return function($service_id) {
+            return [$service_id, 'handle'];
+        };
+    }
+}

tests/Handler/CallableMap/Fixtures/CommandToHandlerMapper.php

@@ -0,0 +1,32 @@
+<?php
+namespace SimpleBus\Message\Tests\Handler\CallableMap\Fixtures;
+
+class CommandToHandlerMapper implements \ArrayAccess
+{
+    public function offsetExists($index)
+    {
+        return class_exists($this->mapCommandToHandler($index), true);
+    }
+
+    public function offsetGet($index)
+    {
+        return $this->mapCommandToHandler($index);
+    }
+
+    public function offsetSet($offset, $value)
+    {
+
+    }
+
+    public function offsetUnset($offset)
+    {
+
+    }
+
+    private function mapCommandToHandler($command_FQCN)
+    {
+        // this is the strategy to map command to handler
+        return $command_FQCN . "Handler";
+    }
+
+}

tests/Handler/CallableMap/Fixtures/DummyCommand.php

@@ -0,0 +1,7 @@
+<?php
+namespace SimpleBus\Message\Tests\Handler\CallableMap\Fixtures;
+
+class DummyCommand
+{
+
+}

tests/Handler/CallableMap/Fixtures/DummyCommandHandler.php

@@ -0,0 +1,10 @@
+<?php
+namespace SimpleBus\Message\Tests\Handler\CallableMap\Fixtures;
+
+class DummyCommandHandler
+{
+    public function handle(DummyCommand $command)
+    {
+
+    }
+}