Include the DicomImagePrintTags.py output in Sphinx docs #1803
Conversation
|
|
||
| # --- hide: start --- | ||
| import subprocess | ||
| result = subprocess.call(['python', |
There was a problem hiding this comment.
Please see this change for a better way to get the current python executable.
64bd1f8
|
Looks pretty good. |
|
I've changed the code to eliminate the trailing whitespace, and improve the method of determining the python executable. But I don't know how to get the ghostflow check to re-run with my new commit. Also, is there a way to stop the old tests and restart with the new code? I tried clicking the "Re-run" button next to the ghostflow-check-master, but it's just spinning. |
|
Ghostflow is checking the individual commits and incremental changes. To address that error the commit needs to be changed. All three of these commits could be squashed or fixed up into one commit. You can use something like an interactive rebase onto origin/master to accomplish this: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History |
Added sphinx_exec_code directive and used it to run the Python example as a subprocess in the rst file using the Image0075.dcm as input.
mbopfNIH
force-pushed
the
EmbedDicomTagOutput
branch
from
151fc30
to
5d3de4b
Compare
|
Made suggested changes to get correct python executable, fixed ghostflow issue, and squashed commits. Build appears to be failing only because of that numpy read-only issue #1805 |
| @@ -2,3 +2,4 @@ sphinx-tabs | |||
| cmake | |||
| sphinx_rtd_theme | |||
| sphinx~=5.3.0 | |||
| sphinx_exec_code~=0.8 | |||
There was a problem hiding this comment.
SimpleITK is also going to be needed here.
There was a problem hiding this comment.
Right. Should I specify a version? Maybe >=2.2 ?
There was a problem hiding this comment.
Okay, but that wouldn't match 2.3 and above, right? So would that require an update this requirements.txt each time we push a minor release?
There was a problem hiding this comment.
Yes. But it would also ensure if an incompatible change was made the older versions could still be built.
|
I may have done an unnecessary merge to get my branch synced with the upstream master. But the code change is simply the extra simpleitk~=2.2.0 in requirements.txt. |
|
The way to update a topic or PR branch with the changes of master is to rebase it onto the master branch. We don't want the commit history to have unnecessary merges in the history which would create confusion and clutter. Also, the changes from master were not needed for this topic/PR. |
Added sphinx_exec_code directive and used it to run the Python example as a subprocess in the rst file using the Image0075.dcm as input.
Fixes issue #1798.