Merge pull request #6718 from albertlast/db_not_null

Fixed boolean invert in not_null columns
SimpleMachines · Apr 28, 2021 · 98ba922 · 98ba922
2 parents 42204c5 + ec73f97
commit 98ba922
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Sources/DbPackages-mysql.php b/Sources/DbPackages-mysql.php
@@ -396,9 +396,9 @@ function smf_db_change_column($table_name, $old_column, $column_info)
 
 	// backward compatibility
 	if (isset($column_info['null']))
-		$column_info['not_null'] != $column_info['null'];
+		$column_info['not_null'] = !$column_info['null'];
 	if (isset($old_info['null']))
-		$old_info['not_null'] != $old_info['null'];
+		$old_info['not_null'] = !$old_info['null'];
 	// Get the right bits.
 	if (!isset($column_info['name']))
 		$column_info['name'] = $old_column;

diff --git a/Sources/DbPackages-postgresql.php b/Sources/DbPackages-postgresql.php
@@ -446,7 +446,7 @@ function smf_db_change_column($table_name, $old_column, $column_info)
 
 	// backward compatibility
 	if (isset($column_info['null']))
-		$column_info['not_null'] != $column_info['null'];
+		$column_info['not_null'] = !$column_info['null'];
 
 	// Check it does exist!
 	$columns = $smcFunc['db_list_columns']($table_name, true);