Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachment downloads - if a file has an entity in the filename (e.g., &), it is entity-encoded in the name upon download #7785

Open
sbulen opened this issue Jul 7, 2023 · 0 comments · May be fixed by #7824
Open

Attachment downloads - if a file has an entity in the filename (e.g., &), it is entity-encoded in the name upon download #7785

sbulen opened this issue Jul 7, 2023 · 0 comments · May be fixed by #7824
Labels
Attachments

Comments

@sbulen
Copy link
Contributor

sbulen commented Jul 7, 2023 •
edited

Description

Attachment downloads - if a file has an entity in the filename (e.g., &), it is entity-encoded in the name upon download.

Steps to reproduce

  1. Rename a file so it has an & in it, e.g., "Слaва&Слaва.jpg"
  2. Upload it to SMF; everything works & is displayed OK, however...
  3. Download the file
  4. It will be renamed to "Слaва&Слaва.jpg"

Environment (complete as necessary)

  • Version/Git revision: 2.1.4
  • Database Type: mysql
  • Database Version: 8.0
  • PHP Version: 8.2

Additional information/references

From the forum: https://www.simplemachines.org/community/index.php?msg=4155733
BrickOzp added a commit that referenced this issue Jul 7, 2023
@BrickOzp
Fix attachment names with html entities.
b97db1b 
Name the attachment with the correct name at download.

Fixes: #7785

Signed-off-by: Oscar Rydhé <oscar.rydhe@gmail.com>
@BrickOzp BrickOzp mentioned this issue Jul 7, 2023
Closed
BrickOzp added a commit to BrickOzp/SMF2.1 that referenced this issue Aug 10, 2023
@BrickOzp
Fix attachment names with html entities.
c2d0ed1 
Name the attachment with the correct name at download.

Fixes: SimpleMachines#7785

Signed-off-by: Oscar Rydhé <oscar.rydhe@gmail.com>
BrickOzp added a commit to BrickOzp/SMF2.1 that referenced this issue Aug 10, 2023
@BrickOzp
Fix attachment names with html entities.
8917498 
Name the attachment with the correct name at download.

Fixes: SimpleMachines#7785

Signed-off-by: Oscar Rydhé <oscar.rydhe@gmail.com>
@BrickOzp BrickOzp linked a pull request Aug 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Attachments
Projects
None yet
Milestone
No milestone
1 participant
@sbulen