Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic fixes #2496

Merged
merged 2 commits into from Nov 18, 2014
Merged

Generic fixes #2496

merged 2 commits into from Nov 18, 2014

Conversation

XinYenFon
Copy link
Contributor

! Glow changes applied (fixes #1545)
! Shadow changes applied
! Text changes on popup/more (fixes #2453)

Since glow/shadow get some changes no need to remove them (they look fine enough) :P fixes #1684
Signed-off-by: Antes antes@simplemachines.org

! Schemaless links and images
! Glow changes applied
! Shadow changes applied
! Text changes on popup/more

Signed-off-by: Antes <antes@simplemachines.org>
@XinYenFon XinYenFon changed the title This needs some test, especially SSL enabled forums. Generic fixes Nov 15, 2014
@Dragooon
Copy link
Contributor

The change for schemaless URLs won't actually allow having [url=//site.com], would it (which is what @Arantor has created the issue about)? It'll simply change default schema from http:// to whatever the schema the user is accessing the site from, which can cause problems for SSL users.

@Oldiesmann
Copy link
Contributor

That's my understanding.

@Oldiesmann
Copy link
Contributor

Since SMF appears to already match URLs without no schema and no "//" on them, theoretically all we'd have to do to support this is just add && strpos($data[0], '//') !== 0 to those conditional statements.

@Arantor
Copy link
Contributor

Arantor commented Nov 17, 2014

I really don't think it's quite that simple. Take a look at fixTags.

@XinYenFon
Copy link
Contributor Author

yea that seems bit lovely

@XinYenFon
Copy link
Contributor Author

How about we add protocols as http:// https:// and // since
[html]<a href="//mysite.com">MySite</a>[/html] has no problem... I'm not sure how this $replace thing works... I need to look for it too... (not gonna lie bit confused)...

@Arantor
Copy link
Contributor

Arantor commented Nov 18, 2014

Of course the html tag version works without any problems, it's completely unchecked for such things.

You will need to be more creative in fixing it than that. I will see if I fixed this at some point in the past, because I think I did.

Signed-off-by: Antes <antes@simplemachines.org>
Oldiesmann added a commit that referenced this pull request Nov 18, 2014
@Oldiesmann Oldiesmann merged commit 77f6497 into SimpleMachines:release-2.1 Nov 18, 2014
@XinYenFon XinYenFon deleted the generic_fix branch November 21, 2014 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

smileys issues Remove useless/unused bbc's Glow & shadow BBC
4 participants