New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic fixes #2496
Generic fixes #2496
Conversation
! Schemaless links and images ! Glow changes applied ! Shadow changes applied ! Text changes on popup/more Signed-off-by: Antes <antes@simplemachines.org>
The change for schemaless URLs won't actually allow having [url=//site.com], would it (which is what @Arantor has created the issue about)? It'll simply change default schema from http:// to whatever the schema the user is accessing the site from, which can cause problems for SSL users. |
That's my understanding. |
Since SMF appears to already match URLs without no schema and no "//" on them, theoretically all we'd have to do to support this is just add |
I really don't think it's quite that simple. Take a look at fixTags. |
yea that seems bit lovely |
How about we add protocols as http:// https:// and // since |
Of course the html tag version works without any problems, it's completely unchecked for such things. You will need to be more creative in fixing it than that. I will see if I fixed this at some point in the past, because I think I did. |
Signed-off-by: Antes <antes@simplemachines.org>
! Glow changes applied (fixes #1545)
! Shadow changes applied
! Text changes on popup/more (fixes #2453)
Since glow/shadow get some changes no need to remove them (they look fine enough) :P fixes #1684
Signed-off-by: Antes antes@simplemachines.org