Change BoardIndex Templates to be more flexible #4310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This technically adds a feature, but this feature prevents modifications from needing to modify the template if they need to inject a "fake" board. This also allows us to more easily handle redirects differently than boards. Signed-off-by: jdarwood007 <unmonitored+github@sleepycode.com>
XinYenFon
approved these changes
Sep 17, 2017
| @@ -178,6 +132,140 @@ function template_main() | |||
| } | |||
|
|
|||
| /** | |||
| * Outs the board icon for a standard board. | |||
There was a problem hiding this comment.
Nit: "Outs the..." is weird English. This should probably be "Outputs the..." or (better) "Prints the..."
Sesquipedalian
requested changes
Sep 25, 2017
|
|
||
| /** | ||
| * Outs the board lastposts for a standard board or a redirect. | ||
| * This gets hidden on mobile if $board['last_post']['id'] is empty by the main template. |
There was a problem hiding this comment.
Nit: this comment is unclear.
Signed-off-by: jdarwood007 <unmonitored+github@sleepycode.com>
|
Thanks, I like it as well. SimpleDesk and other mods will be able to easily add "fake" boards now with custom content for the all the columns. The code is easier to read as well and should be easier on theme developers to make changes to it. Updated the comments. |
Sesquipedalian
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This technically adds a feature, but this feature prevents modifications from needing to modify the template if they need to inject a "fake" board. This also allows us to more easily handle redirects differently than boards.
@antes You may want to review this.
@Gwenwyfar Antes thinks you may be interested.
Signed-off-by: jdarwood007 unmonitored+github@sleepycode.com