Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put back missing ORDER BY so that ssi_recentTopics is ordered as per SMF2.0. #5114

Merged
merged 3 commits into from Nov 6, 2018
Merged

Put back missing ORDER BY so that ssi_recentTopics is ordered as per SMF2.0. #5114

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24ba6f8
Put back missing ORDER BY so that posts are ordered as per SMF2.0. Si…
tinoest Nov 4, 2018
1c8111b
Add id_last_msg to SELECT
tinoest Nov 4, 2018
6c8bf5e
Remove newline
tinoest Nov 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions SSI.php
View file
Open in desktop
Expand Up @@ -578,7 +578,7 @@ function ssi_recentTopics($num_recent = 8, $exclude_boards = null, $include_boar
// Find all the posts in distinct topics. Newer ones will have higher IDs.
$request = $smcFunc['db_query']('substring', '
SELECT
mf.poster_time, mf.subject, ml.id_topic, mf.id_member, ml.id_msg, t.num_replies, t.num_views, mg.online_color,
mf.poster_time, mf.subject, ml.id_topic, mf.id_member, ml.id_msg, t.num_replies, t.num_views, mg.online_color, t.id_last_msg
IFNULL(mem.real_name, mf.poster_name) AS poster_name, ' . ($user_info['is_guest'] ? '1 AS is_read, 0 AS new_from' : '
IFNULL(lt.id_msg, IFNULL(lmr.id_msg, 0)) >= ml.id_msg_modified AS is_read,
IFNULL(lt.id_msg, IFNULL(lmr.id_msg, -1)) + 1 AS new_from') . ', SUBSTRING(mf.body, 1, 384) AS body, mf.smileys_enabled, mf.icon
Expand All @@ -589,7 +589,8 @@ function ssi_recentTopics($num_recent = 8, $exclude_boards = null, $include_boar
LEFT JOIN {db_prefix}log_topics AS lt ON (lt.id_topic = t.id_topic AND lt.id_member = {int:current_member})
LEFT JOIN {db_prefix}log_mark_read AS lmr ON (lmr.id_board = t.id_board AND lmr.id_member = {int:current_member})' : '') . '
LEFT JOIN {db_prefix}membergroups AS mg ON (mg.id_group = mem.id_group)
WHERE t.id_topic IN ({array_int:topic_list})',
WHERE t.id_topic IN ({array_int:topic_list})
ORDER BY t.id_last_msg DESC',
array(
'current_member' => $user_info['id'],
'topic_list' => array_keys($topics),
Expand Down