Show in search only approved message when needed fixes #5534

[albertlast]

The performance impact here is less big as expected.

Another suprise for me was,
that $modSettings['postmod_active'] && !allowedTo('approve_posts')
was not enough.
Since the board manager can see now unapproval message too,
so i had to add him to the check.

issue: #5534

[live627]

approve_posts is a board permission, meaning that you must build and check it differently. Example:

https://github.com/SimpleMachines/SMF2.1/blob/ed54e36517065b22151783a6b246347efa14e286/Sources/PostModeration.php#L61-L77

And then inject it into the query

https://github.com/SimpleMachines/SMF2.1/blob/ed54e36517065b22151783a6b246347efa14e286/Sources/PostModeration.php#L196

[albertlast]

I don't get it,
maybe you want to create own pr.

[Sesquipedalian]

The manage_boards permission should not be part of this logic. That permission does not give the ability to approve or disapprove of posts or topics.

[albertlast]

but the manage_boards got the right to see them,
so he should be able to search them?

[Sesquipedalian]

but the manage_boards got the right to see them,
so he should be able to search them?

No, he doesn't. Please see further discussion in #5534.

[albertlast]

So i removed the manage_boards check.

clicked by accident

[albertlast]

@Sesquipedalian can i close than this pr?

[Sesquipedalian]

Sure