Upgrader - 1.x issues - alt approach

[sbulen]

Fixes #5741
Fixes #5750
Fixes #5751
Fixes #5797

This supersedes #5752 .

I've tested the following variations of upgrades:

• yabbse 1.5.5 => 2.1
• 1.0.23 (vanilla) => 2.1
• 1.1.21 (vanilla) => 2.1
• 2.0.15 (vanilla) => 2.1
• 2.0.15 (test copy of my forum) => 2.1

In each of the following environments, including all updates thru 9/9/19:

• WAMP, PHP 7.2, MySQL 5.7
• Linux, PHP 5.4, MySQL 5.7

If others could test, that'd be welcome! Especially if you have a 1.0 or 1.1 environment with real data in it...

EDIT: Notes on yabbse upgrades:

• Tested with 1.5.5, I know 1.5.0 has a completely different db structure & won't work

[tinoest]

To my knowledge SMF 1.1 never supported PGSQL or at least it didn’t when I looked to switch a forum in 2009 to SMF. I don’t think an upgrader from 1.x to 2.1 is required for SMF 2.1

[sbulen]

The upgrade scripts are also used in the support forum to attempt to correct DB issues with forums.

This is why, when running a 2.1 upgrade, it runs the 2.0 upgrade step as well as the 2.1 upgrade step.

We may have pg 2.0 forums out there, and these scripts will be run against them.

So... To use a specific example... albertlast's suggestion above makes sense, in that, we have removed from the mysql 2.0 file the "let's add this old theme" and in fact replaced it with "let's remove an older now-unsupported theme" logic.

I agree with albertlast's specific example above. I.e., an older 2.0 pg forum may still have those funky old theme settings in them, if it had once been 1.x in the past.

I am just concerned with how far to take it... Especially since I don't have a pg forum to test on & I am very uncomfortable making changes that I cannot test.

[sbulen]

@albertlast - done.
If you could test a 2.0 to 2.1 pg upgrade, that would be appreciated.

[albertlast]

Based of the amount of errors in the pg file i don't need to try to upgrade from 2.0 to 2.1

[sbulen]

This is another one I'd target for RC3. The sooner folks can upgrade cleanly, the better.