Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check attachment and avatar folders before upgrade #7568

Merged
merged 8 commits into from Oct 30, 2022

Conversation

sbulen
Copy link
Contributor

@sbulen sbulen commented Oct 21, 2022

Fixes #7555

If folders are not found, warnings are produced:
image

Also, if we are rerunning the upgrader, a new option has been added to allow for rerunning the attachment conversion:
att_dir_option

Signed by Shawn Bulen, bulens@pacbell.net
Signed by Shawn Bulen, bulens@pacbell.net
Signed by Shawn Bulen, bulens@pacbell.net
Signed by Shawn Bulen, bulens@pacbell.net
@sbulen sbulen marked this pull request as ready for review October 23, 2022 05:37
@sbulen sbulen removed the PR: draft label Oct 24, 2022
Signed by Shawn Bulen, bulens@pacbell.net
@sbulen sbulen added this to the 2.1.3 milestone Oct 28, 2022
@sbulen
Copy link
Contributor Author

sbulen commented Oct 28, 2022

Testing looks good. I'd appreciate a peek before I merge!

Copy link
Contributor

@DiegoAndresCortes DiegoAndresCortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original issue didn't happen, but only tested one upgrade. I'll try to check again later

other/upgrade.php Show resolved Hide resolved
Themes/default/languages/Install.english.php Outdated Show resolved Hide resolved
Signed by Shawn Bulen, bulens@pacbell.net
Signed by Shawn Bulen, bulens@pacbell.net
Signed by Shawn Bulen, bulens@pacbell.net
@sbulen
Copy link
Contributor Author

sbulen commented Oct 28, 2022

So, to test, you first gotta break the upgrader... I usually just rename the attachment folder. This will show you the new warnings.

To test the restart option, you can subsequently fix the attachment folder name then rerun the upgrader. You should get the new option to rerun the attachment conversion.

@sbulen
Copy link
Contributor Author

sbulen commented Oct 30, 2022

Lots of testing completed, I am going to go ahead & merge this.
image

@sbulen sbulen merged commit aa2f168 into SimpleMachines:release-2.1 Oct 30, 2022
@pr-triage pr-triage bot added the PR: merged label Oct 30, 2022
@sbulen sbulen deleted the check_att_av_folders branch October 30, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm attachment dirs (and avatar dir, & custom avatar dir) exist before upgrade
2 participants