[2.1] Improve smileys popup behavior #7762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
live627
reviewed
May 31, 2023
DiegoAndresCortes
force-pushed
the
smileys-popup
branch
from
e3955dc
to
2a88456
Compare
|
Can you rebase this now that #7971 has been merged? This now has merge conflicts. |
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com>
DiegoAndresCortes
force-pushed
the
smileys-popup
branch
from
2a88456
to
526f1b5
Compare
|
Done |
|
How does this look to you, @live627? |
live627
reviewed
Jan 11, 2024
Signed-off-by: Diego Andrés <diegoandres_cortes@outlook.com> Co-authored-by: John Rayes <live627@gmail.com>
DiegoAndresCortes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now stays in place, even without smileys present on the editor