Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.css #982

Closed
wants to merge 1 commit into from
Closed

Update index.css #982

wants to merge 1 commit into from

Conversation

Hristo-
Copy link
Contributor

@Hristo- Hristo- commented Dec 5, 2013

Boards on Ignore Boards Options page should be in 2 columns (.floatleft and .floatright), but due to 90% that was not possible.

P. S. Registered here a few hours ago, have no idea if this is the right way to do it :/

Boards on Ignore Boards Options page should be in 2 columns (.floatleft and .floatright), but due to 90% that was not possible.
@MissAllSunday
Copy link
Contributor

Hi @Hristo- thank you for your interest and the PR :)

Yes, git and/or github can be somehow complicated to use, on the repo main page there are some instructions on how to branch and submit pull requests (PR) https://github.com/SimpleMachines/SMF2.1/blob/release-2.1/README.md

Just be sure to sign off all your commits otherwise we won't be able to use your code.

You can delete your branch both form your local repo and your own fork repo, doing that will close this PR

@Hristo-
Copy link
Contributor Author

Hristo- commented Dec 5, 2013

Thank you for the clarification. I deleted the repo a few hours ago and the PR is still open though.

I think I figured out how to proceed, but I have one question regarding the sigh-off - is it enough if I include in each PR's description the next text:

Signed-off-by: Hristo- "my email at github"

P. S. The "How to create Git aliases" link inside Readme is not working.

@MissAllSunday
Copy link
Contributor

Oh yeah, pretty weird it wasn't deleted when you deleted your branch.

Well, it would be preferred if you sign off every commit you made, that way we can be absolutely sure you are in agreement with our Developer's certificate of origin.

Most of the UIs for git does have a way for making the sign off pretty easy, I use the default windows UI and it has a handy button for it or if you prefer to use the command line thats where aliases comes in handy too.

Thanks for reporting the broken link, I'll update it with a link to git's wiki instead: https://git.wiki.kernel.org/index.php/Aliases

OK then I'm gonna close this PR and we're looking forward to see your contributions 😄

MissAllSunday added a commit to MissAllSunday/SMF2.1 that referenced this pull request Dec 5, 2013
SimpleMachines#982

Signed-off-by: Suki <suki@missallsunday.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants