Skip to content

Commit

Permalink
$member['show_email'] makes no sense here, change it
Browse files Browse the repository at this point in the history
$member['show_email'] is true when the user isn't a guest and the member is the user him/herself, OR when the user is allowed to moderate the forum.
Since users can't add themselves to the buddy/ignore lists it makes no sense to use this over the $context['can_moderate_forum'] variable.

Moreover, if the user WAS able to add themselves, this would result in a header/column mismatch.

Signed-off-by: NanoSector <rick.2889@gmail.com>
  • Loading branch information
NanoSector committed Aug 14, 2018
1 parent b6863d4 commit 8763e61
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Themes/default/Profile.template.php
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ function template_editIgnoreList()
<a href="', $member['online']['href'], '"><span class="' . ($member['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $member['online']['text'] . '"></span></a>
</td>';

if ($member['show_email'])
if ($context['can_moderate_forum'])
echo '
<td>
<a href="mailto:' . $member['email'] . '" rel="nofollow"><span class="generic_icons mail icon" title="' . $txt['email'] . ' ' . $member['name'] . '"></span></a>
Expand Down

0 comments on commit 8763e61

Please sign in to comment.