Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow multiple variations of the same gmail address #240

Closed
Oldiesmann opened this issue Nov 22, 2012 · 18 comments
Closed

Don't allow multiple variations of the same gmail address #240

Oldiesmann opened this issue Nov 22, 2012 · 18 comments

Comments

@Oldiesmann
Copy link
Contributor

GMail, unlike many other providers, allows you to format your email address using dots - someone@gmail.com is exactly the same address as "s.o.m.e.o.n.e@gmail.com", though SMF doesn't think so.

I have seen several instances of spammers registering multiple accounts using multiple variations of the same address.

Unfortunately, I'm not sure it's easy to do this as we'd have to do a WHERE STR_REPLACE(".", "", email_address) (or something similar) in the DB query, and I don't know if it's very efficient to do that, especially on large forums.

@emanuele45
Copy link
Contributor

Not only that, stripping all the "." would affect also the domain, so that email addresses like: myname@my.domain.tld to myname@mydomaintld, something that probably we don't want...

Probably to have something like that the best is "cleanup" the email addresses before they are saved into the database and then strip the "." php-side and do the ban query on the "clean" email.
I would also restrict this behaviour to certain domains only, and of course have the list of domains changeable somewhere in the admin area (anti-spam?) :P).

@matthew-kerle
Copy link

Is this something we should implement? If strpos gmail, strip all periods prior to instance of @?

@joshuaadickerson
Copy link
Contributor

The email spec states that some other things like + are also legal but are
not separate addresses.

On Thu, Dec 6, 2012 at 10:22 AM, Matthew K notifications@github.com wrote:

Is this something we should implement? If strpos gmail, strip all periods
prior to instance of @?


Reply to this email directly or view it on GitHubhttps://github.com//issues/240#issuecomment-11089439.

@live627
Copy link
Contributor

live627 commented Dec 8, 2012

No. Just... no.

@emanuele45
Copy link
Contributor

What part you don't agree with live627? The entire gmail (maybe others) discussion or one of the other suggestions?

@live627
Copy link
Contributor

live627 commented Dec 8, 2012

I see this becoming a form of voodoo magic. What happens when someone signs
up with a Gmail account that has a dot in it?

EDIT: I didn't know that Gmail discarded dots in their accounts. And I even
use them as my email provider! Fancy that...

II think my argument is null and void.

On Sat, Dec 8, 2012 at 6:22 AM, emanuele45 notifications@github.com wrote:

What part you don't want live627? The entire gmail (maybe others)
discussion or one of the other suggestions?


Reply to this email directly or view it on GitHubhttps://github.com//issues/240#issuecomment-11158611.

@joshuaadickerson
Copy link
Contributor

I agree with not implementing it. It has come up before. If people are
having an issue with it, it should be addressed with a customization. Can
you ban with a regular expression? That would be a better feature.

On Sat, Dec 8, 2012 at 1:22 PM, John Rayes notifications@github.com wrote:

I see this becoming a form of voodoo magic. What happens when someone
signs
up with a Gmail account that has a dot in it?

EDIT: I didn't know that Gmail discarded dots in their accounts. And I
even
use them as my email provider! Fancy that...

II think my argument is null and void.

On Sat, Dec 8, 2012 at 6:22 AM, emanuele45 notifications@github.com
wrote:

What part you don't want live627? The entire gmail (maybe others)
discussion or one of the other suggestions?


Reply to this email directly or view it on GitHub<
https://github.com/SimpleMachines/SMF2.1/issues/240#issuecomment-11158611>.


Reply to this email directly or view it on GitHubhttps://github.com//issues/240#issuecomment-11161701.

@Oldiesmann
Copy link
Contributor Author

@joshuaadickerson Banning with regular expressions wouldn't do any good here unless you can somehow say "match this string with 0 or 1 dots after each character except the last one", and even then that would only work for one specific address.

I don't want to ban all dotted gmail addresses as there are legitimate uses for the feature (though I can't see any reason why you'd need to use more than one dot, and have banned "..*@gmail.com" on at least one forum), but it's a bit annoying that there's no easy way to prevent this obvious workaround.

@matthew-kerle
Copy link

As of now, SMF could see "my.name@gmail.com" and "myname@gmail.com" as two completely different email addresses, although if you email both, it'll go to the same account. I personally see this as a flaw in how SMF handles Gmail addresses, which theoretically then should be resolved.

It'd be as simple as stripping periods ahead of the @ symbol and THEN seeing if a member is registered with that email. Heck, you could even save them however they were entered, and then when doing the search just do the same regex.

@Arantor
Copy link
Contributor

Arantor commented Dec 31, 2012

And all of that pales into insignificance when you realise that any domain that uses Google Apps can potentially do exactly the same thing...

@mikemill
Copy link
Contributor

@Arantor Google Apps treat dots in the email address strictly. So john.doe@foo.com is a different box than johndoe@ and john.do.e@

@mikemill
Copy link
Contributor

@Arantor
Copy link
Contributor

Arantor commented Dec 31, 2012

Huh, I thought it did. Wish I'd have known that last week, I could have saved myself a silly amount of work.

@Xarcell
Copy link

Xarcell commented Jan 15, 2014

Reminder: https://support.google.com/a/answer/33386?hl=en less than a month away. Should this issue be closed?

@Arantor
Copy link
Contributor

Arantor commented Jan 15, 2014

Google Apps and Gmail are two different things as pointed out previously and in that link.

@Xarcell
Copy link

Xarcell commented Jan 15, 2014

I misunderstood the the link as saying. I thought it was saying various dots within a gmail would no longer work or be considered different email addressed.

@jasonclemons
Copy link

I think we can close this, since it only affects a single service (GMail), it wouldn't be worth putting forth the effort to put it into effect. There are other, better way at preventing spam.

@live627 live627 closed this as completed Aug 11, 2015
@jdarwood007
Copy link
Member

Admins themselves can get around this by creating a ban .@gmail.com and disallowing it to register. SMF only uses * for the wildcard and uses the literal .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants