Uses redirectexit and fixes #3798 #3799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Colin Schoen <cschoen@berkeley.edu>
Signed-off-by: Colin Schoen <cschoen@berkeley.edu>
|
Fixing indentation, one moment... |
Signed-off-by: Colin Schoen <cschoen@berkeley.edu>
live627
requested changes
Jan 5, 2017
|
Working locally. What goes wrong when using them? |
|
iDunno
|
|
Image larger than threshold is working. I'll try the other tomorrow |
|
Deleting the image and refreshing the page is also working when checking out this PR locally. Not able to replicate any issues. @live627 |
|
|
live627
approved these changes
Jan 5, 2017
|
No worries. Thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use redirectexit instead of manually changing headers. Fixes #3798
@jdarwood007