$context['login_cookie_times'] is not defined for all path

[albertlast]

Look like that exists some path where login page is called,
where the $context['login_cookie_times'] is not defined.

Related smf post: https://www.simplemachines.org/community/index.php?topic=561477.0
related pr: #4863
commited by @jdarwood007

https://github.com/SimpleMachines/SMF2.1/blob/8902c394cf9228726a66db41053fed3131a262ff/Themes/default/Login.template.php#L259

Requirements

Calendar must be enabled
Guests shouldn't have permissions to see Calendar

Steps to reproduce

• Bein logged, on board index, right-click the "Logout" button and select "Open in a new tab".
• On board index now click "Upcoming Calendar". You will be redirected to the login page (which needs a bit of tweak since the time to stay logged in is not working). You may now login again and check the error log. The errors are:

[frandominguezl]

I didn't know you already tracked this. I made an issue about it as well, now closed.

[sbulen]

I get this pretty consistently after a session timeout. It corresponds to the login form not having the time dropdown properly populated. So another way to reproduce is to set the timeout to an hour and resume activity after an hour has passed:

[albertlast]

@frandominguez03 like i mention in the irc, you didn't fix the issue, you only hide error message.

The issue keep open.

[frandominguezl]

@albertlast If I haven't submitted a pull request yet its because I'm not sure how to fix it.

[SychO9]

And same for maintenance mode, $context['login_cookie_times'] is undefined

[jdarwood007]

I will look into it. Seems I may need to call this sooner. So many adhoc places we call the login form.

[albertlast]

Look like that still exists path where the var is not setted:

@jdarwood007 https://www.simplemachines.org/community/index.php?topic=562437.msg3990544#msg3990544