Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrader - challenges with 1.0 to 2.1 upgrade #5750

Closed
sbulen opened this issue Jul 26, 2019 · 6 comments · Fixed by #5755
Closed

Upgrader - challenges with 1.0 to 2.1 upgrade #5750

sbulen opened this issue Jul 26, 2019 · 6 comments · Fixed by #5755
Assignees
Milestone

Comments

@sbulen
Copy link
Contributor

sbulen commented Jul 26, 2019

Description

Many issues with attempting to upgrade from 1.0.x. The upgrader tries to do it, so it ought to work.

Causes of various issues:

  • Compliance to STRICT mysql, so the old syntax doesn't work
  • 'Previous execution' logic not working
  • The 1.0 script also updates from YABB, and references YABB tables & fields
  • The 1.0 script must also, of course, repair any issues found with 1.0; there is at least one instance where the 1.0.x installer creates different field names than the app

I attempted a YABBSE install to test as well, but no luck, it just stared at me...

Steps to reproduce

  1. Install any vanilla 1.0 version. (I've been using 1.0.23.)
  2. Upgrade to 2.1

Environment (complete as necessary)

  • Version/Git revision: Current
  • Database Type: MySQL
  • Database Version: 5.7
  • PHP Version: 5.6

Additional information/references

1-0-upgrade-5
1-0-upgrade-4
1-0-upgrade-3
1-0-upgrade-2
1-0-upgrade-1
1-0-upgrade-8
1-0-upgrade-7
1-0-upgrade-6

@sbulen
Copy link
Contributor Author

sbulen commented Jul 26, 2019

Note: the UTF8 conversion has issues with 1.0 as well. This is specific to 1.0. 1.1 & 2.0 upgrades test OK. On the left is a "Kermit test" of a 1.0.23 upgrade (bad), on the right is a 1.1.21 upgrade (good):
image

image

@sbulen
Copy link
Contributor Author

sbulen commented Jul 30, 2019

OK... I no longer think the utf8 issue noted above has anything to do with the upgrader.

First, the data is clearly double-encoded - even in 1.0.23, before the upgrade. After the upgrade, it is untouched (still double-encoded), and in the DB, represents the exact same content as before 1.0.23. The ugrader leaves it alone, as expected.

I suspect this is more of a problem with running 1.0.23 on a recent apache install that wants to speak in utf8.

As such, it is not a problem really with the upgrader; it's the data.

I think we've seen this before in the support forum. It'd be nice to have a "find & fix double-encoded utf8 data" utility hanging around!

@Arantor
Copy link
Contributor

Arantor commented Aug 10, 2019

Also if you were testing the YABB SE part, you need to drop down to PHP 4.x since it predates $_GET and $_POST existing and the legacy method was long since removed.

@sbulen
Copy link
Contributor Author

sbulen commented Aug 10, 2019

Thanks @Arantor ...

I actually tried to install YABBSE but couldn't get it up & running. That explains why!

I don't have access to a php4 environment. My WAMP only goes back to 5.6, & my host only goes back to 5.4.

@Arantor
Copy link
Contributor

Arantor commented Aug 10, 2019

Grab VirtualBox, install an old version of Ubuntu on it, then you can have whatever version of PHP you need... I recently did this for 1.0 and 1.1 so I could check out some themes I had in my archive and take screenshots for references. (Though I went with PHP 5.2 on Ubuntu 12.04, didn't feel the need to go back to really old versions, though isos should be available if you wanted to do so)

@sbulen
Copy link
Contributor Author

sbulen commented Aug 13, 2019

Getting php4 up & running is a windmill I don't want to tilt.

However, with a little effort, Yabbse installs cleanly, with a good file system, db, and settings.php file...

@MissAllSunday MissAllSunday added this to the Final milestone Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants