Refactor Cache API #6013
Merged
Refactor Cache API #6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdarwood007
requested changes
Feb 11, 2020
MissAllSunday
changed the title
MissAllSunday
force-pushed
the
implement_redis
branch
2 times, most recently
from
a20141b
to
5a0ed1d
Compare
|
Note: Travis build is currently failing due to a problem with Travis itself. |
|
To fix Travis builds, please merge release-2.1 into this branch. |
MissAllSunday
force-pushed
the
implement_redis
branch
from
c6b50c2
to
22ed009
Compare
MissAllSunday
force-pushed
the
implement_redis
branch
from
548404d
to
c81efaa
Compare
|
This is now considered done. Please test it specially with the other cache options. |
jdarwood007
reviewed
Feb 17, 2020
live627
reviewed
Feb 17, 2020
live627
reviewed
Feb 17, 2020
MissAllSunday
force-pushed
the
implement_redis
branch
from
c81efaa
to
d80dacb
Compare
|
It seems GitHub ate a lot of commits, will investigate why or try to bring them back. |
|
Found the issue, GitHub for some reason took the same branch as a different one, merged both. |
|
IMO any major refactoring should be postponed for the next major version. |
|
I agree. However, this isn't a major refactor. The abstract class and interface already exists, there is no change in how the cache apis work and are implemented (besides how the current cache info is stored). This changes makes sure anyone wanting to add another cache engine should follow our structure and makes it easier to add more engines. |
|
uhh. okay then...
…On Tue, Feb 25, 2020 at 7:04 AM Michel Mendiola ***@***.***> wrote:
I agree. However, this isn't a major refactor. The abstract class and
interface already exists, there is no change in how the cache apis work and
are implemented.
This changes makes sure anyone wanting to add another cache engine should
follow our structure and makes it easier to add more engines.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6013>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJNN74WAONZI37YHVCGA3REUQNNANCNFSM4KSY5HMQ>
.
|
MissAllSunday
force-pushed
the
implement_redis
branch
from
d869754
to
d99374b
Compare
MissAllSunday
force-pushed
the
implement_redis
branch
from
6bba77e
to
da6ac2d
Compare
|
Bump, we still need a proper API implementation. $cache_accelerator still holds a plain string and a few fixes to the current cache implementation are also included. |
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
…ache versions Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
…sion, fallback to N/A Fixes SimpleMachines#6110 Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Ref: SimpleMachines#5969 Signed-off-by: Jessica González <suki@missallsunday.com>
Ref: SimpleMachines#5969 Signed-off-by: Jessica González <suki@missallsunday.com>
… class Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
MissAllSunday
force-pushed
the
implement_redis
branch
from
32b8d56
to
fc383dc
Compare
Signed-off-by: Jessica González <suki@missallsunday.com>
jdarwood007
reviewed
Oct 24, 2020
| /** | ||
| * Creates the json_encoded array for the current cache option. | ||
| * | ||
| * @return string a json_encoded array with the selected API options |
There was a problem hiding this comment.
There is not json entry anymore, it still is a plain string I just forgot to update the dock block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the current cache API
Tested on Mac Mojave and Ubuntu 18.04.4 using Sqlite, File based and Memcached options.
Fixes #6110