! iPad autocomplete was replacing email address in account settings #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because some browsers ignore the autocomplete directive in form and input fields, the simplest known workaround is display:hidden fields to fake out the browser autocomplete feature. This just makes SMF that much more mobile friendly Signed-off-by: Angelina Belle <angelinabelle1@hotmail.com>
Safari now ignores display:none input fields; use absolute positioning to hide it instead. Signed-off-by: Angelina Belle <AngelinaBelle1@hotmail.com>
|
Fixes #1757 |
Signed-Off-By: Angelina Belle <AngelinaBelle1@hotmail.com>
|
Please merge to work around the ios over eager autocomplete. This PR makes SMF much friendlier to iPad users. |
|
Won't those fake inputs be visible to the user? |
|
They are outside the visible window because of the absolute positioning. If you use hidden, Safari is smart enough to ignore them. |
live627
added a commit
that referenced
this pull request
Jul 24, 2014
! iPad autocomplete was replacing email address in account settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fake name and password fields prevent Safari and chrome from replacing email in account settings.
Signed-off-by: Angelina Belle angelinabelle1@hotmail.com