Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SCEditor to 1.4.7 #2786

Merged
merged 32 commits into from
Apr 2, 2015
Merged

Update SCEditor to 1.4.7 #2786

merged 32 commits into from
Apr 2, 2015

Conversation

live627
Copy link
Contributor

@live627 live627 commented Mar 22, 2015

Fixes #2466

Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
@XinYenFon
Copy link
Contributor

So far I didn't see any problem (is it only me or wysiwyg mode is way more better now?).

edit: anyone can test new version with #2466 ?

cc: @jsgrom

@margarett
Copy link
Contributor

I tested this shortly (not exactly sure what to test 👅 )
Overall looks to work fine. I can't reproduce #2466

There's just something annoying:
a) out of wysiwyg, the cursor shows correctly in the top of the "box". In wysiwyg it starts a bit lower (more in FF than in IE)
b) out of wysiwyg, the insert URL/mail, etc, buttons trigger a popup. In wysiwyg it's a popup but that popup has the "INSERT" text too much dislocated down (doesn't look that good 👅 )

@jsqx
Copy link

jsqx commented Mar 24, 2015

The cursor in IE11 still isn't shown in place. The cursor is flashing beside last emoticon. If you refresh the site the cursor will be flashing in this place.

bad

In the basic editor the cursor is showing in right place in text editor, but if a site is refreshing in browser than this cursor is showing beside this emoticon but back on it place to writing editor.

@live627 live627 added the Editor label Mar 27, 2015
@live627 live627 added this to the Beta 2 milestone Mar 27, 2015
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
@live627
Copy link
Contributor Author

live627 commented Mar 29, 2015

a) out of wysiwyg, the cursor shows correctly in the top of the "box". In wysiwyg it starts a bit lower (more in FF than in IE)

I switch modes in FF and see no movement in the text.

b) out of wysiwyg, the insert URL/mail, etc, buttons trigger a popup. In wysiwyg it's a popup but that popup has the "INSERT" text too much dislocated down (doesn't look that good 👅 )

Fixed

Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
@live627
Copy link
Contributor Author

live627 commented Apr 1, 2015

anyone can test new version with #2466 ?

Yep, this patch definitely fixes it.

Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
…omething must give

Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
@XinYenFon
Copy link
Contributor

I didn't notice any weird thing on Spartan as well, one thing "enter" button moving space to upwards not downwards (Spartan's bug ?).

Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
Signed-off-by: John Rayes <live627@gmail.com>
live627 added a commit that referenced this pull request Apr 2, 2015
Update SCEditor to 1.4.7
@live627 live627 merged commit ba9d2a8 into SimpleMachines:release-2.1 Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Still badly is shown cursor in qucik reply (IE11)
4 participants