Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent ad block plus from hiding the like button #5440

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Prevent ad block plus from hiding the like button #5440

merged 2 commits into from
Feb 19, 2019

Conversation

live627
Copy link
Contributor

@live627 live627 commented Feb 16, 2019

No description provided.

@live627
Prevent ad block plus from hiding the like button
ba0c759 
Signed-off-by: John Rayes <live627@gmail.com>
@live627 live627 added the Theme label Feb 16, 2019
@live627 live627 added this to the RC3 milestone Feb 16, 2019
@SychO9
Copy link
Contributor

SychO9 commented Feb 16, 2019 •
edited

I don't think removing the class is a good idea, it can be really useful for customizations
Also you probably have to edit the one in SSI too

Sesquipedalian
Sesquipedalian requested changes Feb 19, 2019
View reviewed changes
Copy link
Member

@Sesquipedalian Sesquipedalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a different class name would be better than using none at all. Maybe "smflikebutton" would get past AdBlock?

@Sesquipedalian Sesquipedalian merged commit 7b5ec62 into SimpleMachines:release-2.1 Feb 19, 2019
@live627 live627 modified the milestones: RC3, RC2 Feb 19, 2019
@live627 live627 deleted the abp-likes branch February 19, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sesquipedalian Sesquipedalian Sesquipedalian approved these changes

Assignees
No one assigned
Labels
Theme
Projects
None yet
Milestone
RC2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@live627 @SychO9 @Sesquipedalian