Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when calculating huge numbers and then using any operation #224

Closed
AlexanderFL opened this issue Nov 14, 2021 · 8 comments
Closed

Comments

@AlexanderFL
Copy link

How to replicate

  1. Continuously raise a number to some power
  2. Result of the operation is too big, "unknown error occurred" is displayed (result is infinite)
  3. Try to use any operation after that without clearing the screen and the app crashes (fx. - 1)

Gif of these steps

Expected result
Most important is that the app shouldn't crash, and instead maybe display the latest valid result

@tibbi
Copy link
Member

tibbi commented Nov 14, 2021

the attachment is invalid, what do you mean by huge numbers?

@AlexanderFL
Copy link
Author

Odd, link seems to work fine for me. By huge numbers I mean like the result from 9^9^9 which has roughly 400 million digits

@tibbi
Copy link
Member

tibbi commented Nov 14, 2021

oh man, dont expect having support for such numbers, this is not a superscientific calculator

@tibbi tibbi closed this as completed Nov 14, 2021
@AlexanderFL
Copy link
Author

I'm aware that this is a silly use case, but still think that the app shouldn't crash from the results

@AlexanderFL
Copy link
Author

The issue itself is not that that the number itself is huge, it's when the result of the operation is infinite (in the eyes of the computer), the input isn't updated. So next time when a user inputs any arithmetic operation, getSecondValue() is not trying to parse a non-float to a float resulting in the crash. I have a fix ready if you're interested

@tibbi
Copy link
Member

tibbi commented Nov 14, 2021

try upgrading to 5.6.1 if you can still reproduce it

@AlexanderFL
Copy link
Author

this is present in version 5.6.1 as well

@tibbi
Copy link
Member

tibbi commented Nov 15, 2021

sure, just send the fix with a pull request if you have it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants