Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Belgium holidays in English #1906

Open
cacharle opened this issue Dec 13, 2022 · 7 comments
Open

Add Belgium holidays in English #1906

cacharle opened this issue Dec 13, 2022 · 7 comments

Comments

@cacharle
Copy link

There is already the Belgian holidays in Dutch but it would be nice to have them in French aswell.

I don't mind adding this myself if you can point me to the file I need to modify :)

@tibbi
Copy link
Member

tibbi commented Dec 13, 2022

we dont support such country/language specific holidays yet

@cacharle
Copy link
Author

hmmm, can't we just add a Belgium (fr) as a new country? not clean but maybe works..

@cacharle
Copy link
Author

I see you take the holidays from https://holidays.kayaposoft.com/public_holidays.php?year=2021 and there is the french/english translations there aswell.

Would it be possible to download it in English instead of Dutch? I never met a Flemish who doesn't speak English 😅

@cacharle cacharle changed the title Add Belgium holidays in French Add Belgium holidays in English Dec 13, 2022
@tibbi
Copy link
Member

tibbi commented Dec 13, 2022

I take holidays from different sources, that link is just one of them. We can add brackets for countries/regions in the future too.

@cacharle
Copy link
Author

Can't I just add a belgique.ics in /app/src/main/assets/ and add a radio button Belgique for it? or Belgique (fr) to make it clearer.

@tibbi
Copy link
Member

tibbi commented Dec 13, 2022

you can try

@cacharle cacharle mentioned this issue Dec 13, 2022
@eneller
Copy link

eneller commented Feb 16, 2023

see #1978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants