Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add birthdays automatically #620

Open
natrius opened this Issue Sep 12, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@natrius
Copy link

natrius commented Sep 12, 2018

Is it possible to add the birthdays automatically? Because i don't want to think everytime i add another contact to press the button again.
It would be great if this would just be an option in the settings and if ticket the birthdays just gets imported.

@jtj9817

This comment has been minimized.

Copy link
Contributor

jtj9817 commented Jan 29, 2019

@tibbi Since #742 is on the low priority for now, mind if I take a look at this Issue then? I'm not really sure what the implementation should be but if I understand it correctly:

  • SimpleCalendar app is installed, Contact list of phone is retrieved by using the ContactsContract API
  • When the Contact list is retrieved, scan the list and if a Contact has a "Birth Date" information available, add the Name of the Contact and their Birth Date to a list known as "Birthday Events"
  • Birthday Events need to be processed; each item in the list will be processed by iterating through the list and making an API call for each item to be added as an 'Event'
  • All of the above processes can be an option in Settings menu
@tibbi

This comment has been minimized.

Copy link
Member

tibbi commented Jan 29, 2019

not sure what you mean with the third point. Accessing contact birthdays needs the Contacts permission, it is asked once the user triggers the "Add contact birthdays" menu item. Then birthdays could be rechecked periodically somehow in the background.

@jtj9817

This comment has been minimized.

Copy link
Contributor

jtj9817 commented Jan 30, 2019

@tibbi Just rethought about the approach to the problem, seems like we can simplify it better.

  • When the "Add Contact Birthdays" option is selected and the user agrees for Contacts access permission, the app will scan current list of Contacts with their Birth Date available
  • After adding the current list of Contacts with their Birthdays, SimpleCalendar will prompt user if they want to "Automatically Add New Contact Birthdays"
  • Once the option above has been checked, when SimpleCalendar starts up again it will scan the list for a new Contact and if that Contact item has a 'Birth Date' field on it, they will be automatically added
@tibbi

This comment has been minimized.

Copy link
Member

tibbi commented Jan 30, 2019

I think that you can even skip the prompt, just sync it in the background at app start by default. But dont forget checking for the Contacts permission, the user could have revoked it. If he did, just ignore the sync silently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.