Camera UI fixes #348

KryptKode · 2022-09-29T00:13:08Z

Notes

fix the back button bug that prevented exiting the app
remove change bounds animation
handle storage permissions
- handle requesting READ_MEDIA_IMAGES and READ_MEDIA_VIDEO for Android 13+
- request WRITE_EXTERNAL_STORAGE for Android 12 and below
- set the permission WRITE_EXTERNAL_STORAGE to maxSdkVersion=32 in the AndroidManifest
update CameraX to 1.2.0-beta02
update top layout and 1x1 and full screen icons

- handle requesting READ_MEDIA_IMAGES and READ_MEDIA_VIDEO for Android 13+ - request WRITE_EXTERNAL_STORAGE for Android 12 and below - set the permission WRITE_EXTERNAL_STORAGE to maxSdkVersion=32 in the AndroidManifest

tibbi · 2022-09-29T07:08:35Z

the shutter sound plays way too early, before the actual photo is taken. And the top menu after extending the aspect ratio or flashlight are still a bit lower than the main buttons on the main screen. Cant you just use the same margin there? I can see the 4:3 moving a bit after reselectingi t.

tibbi · 2022-09-29T07:10:43Z

and capturing a video crashes right after start on my Android 11,
java.lang.IllegalArgumentException: Failed to determine if primary:DCIM/Camera/VID_20220929_091104.mp4 is child of primary:DCIM: java.io.FileNotFoundException: Missing file for primary:DCIM/Camera/VID_20220929_091104.mp4 at /storage/emulated/0/DCIM/Camera/VID_20220929_091104.mp4
at com.android.internal.content.FileSystemProvider.isChildDocument(FileSystemProvider.java:143)
at android.provider.DocumentsProvider.enforceTree(DocumentsProvider.java:228)
at android.provider.DocumentsProvider.openAssetFile(DocumentsProvider.java:1343)
at android.content.ContentProvider$Transport.openAssetFile(ContentProvider.java:543)
at android.content.ContentProviderNative.onTransact(ContentProviderNative.java:286)
at android.os.Binder.execTransactInternal(Binder.java:1165)
at android.os.Binder.execTransact(Binder.java:1134)
2022-09-29 09:11:04.124 22913-22913/com.simplemobiletools.camera.debug E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.simplemobiletools.camera.debug, PID: 22913
java.lang.IllegalArgumentException: Failed to determine if primary:DCIM/Camera/VID_20220929_091104.mp4 is child of primary:DCIM: java.io.FileNotFoundException: Missing file for primary:DCIM/Camera/VID_20220929_091104.mp4 at /storage/emulated/0/DCIM/Camera/VID_20220929_091104.mp4
at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:172)
at android.database.DatabaseUtils.readExceptionWithFileNotFoundExceptionFromParcel(DatabaseUtils.java:153)
at android.content.ContentProviderProxy.openAssetFile(ContentProviderNative.java:727)
at android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:1835)
at android.content.ContentResolver.openFileDescriptor(ContentResolver.java:1650)
at android.content.ContentResolver.openFileDescriptor(ContentResolver.java:1597)
at com.simplemobiletools.camera.helpers.MediaOutputHelper.getFileDescriptorMediaOutput(MediaOutputHelper.kt:140)
at com.simplemobiletools.camera.helpers.MediaOutputHelper.getVideoMediaOutput(MediaOutputHelper.kt:79)
at com.simplemobiletools.camera.implementations.CameraXPreview.startRecording(CameraXPreview.kt:517)
at com.simplemobiletools.camera.implementations.CameraXPreview.toggleRecording(CameraXPreview.kt:506)
at com.simplemobiletools.camera.activities.MainActivity.handleShutter(MainActivity.kt:423)
at com.simplemobiletools.camera.activities.MainActivity.shutterPressed(MainActivity.kt:411)
at com.simplemobiletools.camera.activities.MainActivity.initButtons$lambda-6(MainActivity.kt:362)
at com.simplemobiletools.camera.activities.MainActivity.$r8$lambda$lY85W6e3V0bThE5d6acXvA3oJAM(Unknown Source:0)
at com.simplemobiletools.camera.activities.MainActivity$$ExternalSyntheticLambda11.onClick(Unknown Source:2)
at android.view.View.performClick(View.java:7520)
at android.view.View.performClickInternal(View.java:7489)
at android.view.View.access$3600(View.java:826)
at android.view.View$PerformClick.run(View.java:28555)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:233)
at android.app.ActivityThread.main(ActivityThread.java:8068)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:631)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:978)

tibbi · 2022-09-29T07:13:07Z

it actually isnt crashing on a fresh install, try checking an upgrade from the old to new version, there are still many people using the old one. That bottom shadow seems to be higher during videos without a reason than at photos. Guess moving the recording time above the shutter button would help, theres still enough place.

KryptKode · 2022-09-29T15:59:31Z

Hi @tibbi,

About the top margin
It is not very visible on my end. Both the main icons and the aspect ratio and flashlight selector icons have been added to a root FrameLayout and the top margin is applied to that.

The only difference I noticed is in the height. So I will set them to be the same height and hopefully, this would correct what you observed.

Shutter sound
Would you want the shutter sound to play at the point when the picture is saved? I am afraid that would be too late. OnePlus app plays it as soon as the capture button is clicked alongside the blinking animation of the screen.

- handle exception when creating media output - if only one resolution is supported, no need to restart the camera

tibbi · 2022-09-30T08:34:36Z

shutter sound has to be played at exact same time as the photo is captured. I moved the phone after hearing the sound and the images were blurry.

tibbi · 2022-10-05T19:47:13Z

it crashes if I use Video mode and click on HD and pick any resolution (4 items available), then click on Photo and click on the aspect ratio picker. Guess it will be because the 16:9 ratio is hidden and you count on 4 items being visible or so.
Process: com.simplemobiletools.camera.debug, PID: 31898
java.lang.IndexOutOfBoundsException: getChildDrawingOrder() returned invalid index 3 (child count is 3)
at android.view.ViewGroup.getAndVerifyPreorderedIndex(ViewGroup.java:2125)
at android.view.ViewGroup.gatherTransparentRegion(ViewGroup.java:7285)
at android.view.ViewGroup.gatherTransparentRegion(ViewGroup.java:7288)
at android.view.ViewGroup.gatherTransparentRegion(ViewGroup.java:7288)
at android.view.ViewGroup.gatherTransparentRegion(ViewGroup.java:7288)
at android.view.ViewGroup.gatherTransparentRegion(ViewGroup.java:7288)
at android.view.ViewGroup.gatherTransparentRegion(ViewGroup.java:7288)
at android.view.ViewGroup.gatherTransparentRegion(ViewGroup.java:7288)
at android.view.ViewGroup.gatherTransparentRegion(ViewGroup.java:7288)
at com.android.internal.policy.DecorView.gatherTransparentRegion(DecorView.java:361)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3271)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2206)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8763)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1352)
at android.view.Choreographer.doCallbacks(Choreographer.java:1149)
at android.view.Choreographer.doFrame(Choreographer.java:1049)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1333)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:233)
at android.app.ActivityThread.main(ActivityThread.java:8068)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:631)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:978)

tibbi · 2022-10-05T19:49:12Z

app/src/main/kotlin/com/simplemobiletools/camera/activities/MainActivity.kt

@@ -606,7 +631,7 @@ class MainActivity : SimpleActivity(), PhotoProcessor.MediaSavedListener, Camera
            toggle_flash.beVisible()
        } else {
            toggle_flash.beInvisible()
-            toggle_flash.setImageResource(R.drawable.ic_flash_off_vector)
+            toggle_flash.icon = AppCompatResources.getDrawable(this, R.drawable.ic_flash_off_vector)


any specific reason for using compat on some places? Just removing Android Studio warnings?

No specific reason. Just an old habit.
Since we have minSDK 29, we can just call getDrawable but then we have the warning on Android Studio.
Do you want me to change this?

you dont need to call any drawable, just set image resource directly, like it used to be

- this seems like a bug on the MaterialToggleGroup; for example, when 4 items are added to it and removed and later on 3 items added, it will crash - the only feasible fix is to create a new MaterialToggleGroup when displaying the options - calling invalidate, removeAllViews, etc do not work

tibbi · 2022-10-06T16:26:19Z

alright, looks good now, will do more testing on different devices and see how it goes :) Thanks

KryptKode added 6 commits September 22, 2022 00:48

fix back button

58bf7fd

remove change bounds animation

67566ee

Merge branch 'master' into feat/camera-x

1ea0664

handle new storage permissions for API 33

d9afde4

- handle requesting READ_MEDIA_IMAGES and READ_MEDIA_VIDEO for Android 13+ - request WRITE_EXTERNAL_STORAGE for Android 12 and below - set the permission WRITE_EXTERNAL_STORAGE to maxSdkVersion=32 in the AndroidManifest

update CameraX

c406636

update top layout and icons

a324da0

KryptKode added 2 commits September 29, 2022 17:00

make all top icons Buttons with same height

c38bab6

minor fixes for media output and toggling resolution

2627638

- handle exception when creating media output - if only one resolution is supported, no need to restart the camera

close image after capturing as Bitmap

315f8f5

tibbi reviewed Oct 5, 2022

View reviewed changes

tibbi merged commit 879251e into SimpleMobileTools:master Oct 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Camera UI fixes #348

Camera UI fixes #348

KryptKode commented Sep 29, 2022

tibbi commented Sep 29, 2022

tibbi commented Sep 29, 2022

tibbi commented Sep 29, 2022

KryptKode commented Sep 29, 2022

tibbi commented Sep 30, 2022 •

edited

tibbi commented Oct 5, 2022 •

edited

tibbi Oct 5, 2022 •

edited

KryptKode Oct 6, 2022

tibbi Oct 6, 2022

tibbi commented Oct 6, 2022

Camera UI fixes #348

Camera UI fixes #348

Conversation

KryptKode commented Sep 29, 2022

Notes

tibbi commented Sep 29, 2022

tibbi commented Sep 29, 2022

tibbi commented Sep 29, 2022

KryptKode commented Sep 29, 2022

tibbi commented Sep 30, 2022 • edited

tibbi commented Oct 5, 2022 • edited

tibbi Oct 5, 2022 • edited

Choose a reason for hiding this comment

KryptKode Oct 6, 2022

Choose a reason for hiding this comment

tibbi Oct 6, 2022

Choose a reason for hiding this comment

tibbi commented Oct 6, 2022

tibbi commented Sep 30, 2022 •

edited

tibbi commented Oct 5, 2022 •

edited

tibbi Oct 5, 2022 •

edited