Feat/multiple timers #285

KryptKode · 2021-09-02T23:56:33Z

Notes

add support for multiple timers
separate timer actions from states by adding a new class TimerEvent to hold actions Reset, Start, Pause, Finish, Refesh that could be performed on a timer.
make windowSoftInputMode=adJustPan for MainActivity
should address this request

Screenshot

screencapture-1631056793013.mov

- feat: separate timer actions from states by adding a new class TimerEvent to hold actions Reset, Start, Pause, Finish, Refesh that could be performed on a timer. - feat: handle multiple countdown timers in the App file by creating a map of the timer id to the countdown timer. - fix: use gson instance from TypeAdapter in Room's Converters class - ref: remove scroll view parent from each timer item, a fix for the keyboard obscuring a label will be implemented in a future commit

- add page indicator - add default timer based on saved prefs when the database is created - post scolling to the first timer when a new timer is added

- this ensures the textfield is always above the keyboard

tibbi · 2021-09-03T07:47:40Z

we have an ic_plus_vector at Simple Commons, use that instead of the newly created ic_add_vector

tibbi · 2021-09-03T07:52:24Z

I would prefer a more compact layout instead of the vertical viewpager, something like at the alarms at the second tab. One where the user could see the labels and timers easily and use them quickly. The current solution could be difficult to manage if there are more than 10 timers.

app/src/main/kotlin/com/simplemobiletools/clock/adapters/TimerAdapter.kt

tibbi · 2021-09-03T07:55:56Z

some text colors and buttons are not updating colors properly, try using light theme for testing too

app/src/main/kotlin/com/simplemobiletools/clock/services/TimerService.kt

KryptKode · 2021-09-03T08:02:45Z

I would make the changes

tibbi · 2021-09-03T08:06:24Z

alright, thanks. I know that the UI changes might need some time and the viewpager you added wont be used, but I sometimes dont know how do I want things to look. I only figure it out once I test one alternative and see that I prefer the other one :)

KryptKode · 2021-09-03T08:19:35Z

alright, thanks. I know that the UI changes might need some time and the viewpager you added wont be used, but I sometimes dont know how do I want things to look. I only figure it out once I test one alternative and see that I prefer the other one :)

No problem. I wanted to preserve the original look and feel. With this change, each item would have the Play/Pause, Reset and Delete buttons. Then a general FAB for adding on the left.

tibbi · 2021-09-03T08:21:39Z

ye it would, but it is hard to manage once you have multiple items

- update commons library

KryptKode · 2021-09-03T18:49:12Z

@tibbi I made the changes. Please take a look

tibbi · 2021-09-06T09:36:18Z

I didnt mean just copying the same Timer UI multiple times vertically, try compressing it like the Alarm view too. At least 6-7 timers should fit onto 1 screen, they should be split with some margin to be able to differentiate them well

tibbi · 2021-09-06T09:37:44Z

show the curent timer and label at the main tab, options like vibrating and ringtone should be shown only after clicking. Somewhat like at the alarms. Deleting should be done with long pressing the timer item, like at alarms too.

- implement EditTimerDialog - adding a new timer would show the dialog - clicking on a timer item would show the dialog

KryptKode · 2021-09-07T20:55:02Z

@tibbi Please check for the play/pause button,

Without highlighted colour	With Highlighted colour

KryptKode · 2021-09-07T20:59:19Z

@tibbi Also, should clicking on the time text give the option to adjust the time or should it be done solely from the edit dialog?
If we allow changing the time by clicking the time text, it might interfere with the long press to select. Also, should there be a delete button for each item?

screencapture-1631048194584.mp4

tibbi · 2021-09-07T21:25:14Z

first lets move the play/pause to the right side, with the timer and label being shown at the left. It will be more compact like that. Delete should be shown at the top menu only after long pressing some item. Regarding the time, make it work like at the Alarm tab. Clicking it should just open the edit dialog, like at clicking the label. Then you have to press the time again to change it.

KryptKode · 2021-09-08T19:03:53Z

Made the changes. Please check. @tibbi

screencapture-1631127086547.mp4

tibbi · 2021-09-10T08:09:21Z

nice, 2 more things.

1.If I launch a timer, background and foreground the app to make the top notification appear, then delete the timer, the notification doesnt disappear. It just stops the countdown.
2. colors are not handled properly, try switching to light theme for some testing

…multiple-timers

KryptKode · 2021-09-10T13:37:06Z

@tibbi I made the changes

tibbi · 2021-09-10T16:31:50Z

if you click on the time, the timer icon above Vibrate is still white. Just switch to light theme and change the background to very light grey to find such issues

KryptKode · 2021-09-10T16:36:26Z

Seen, will fix.

tibbi · 2021-09-10T16:45:16Z

maybe one more thing. If you change the text color, the Play and repeat button colors are not updated

KryptKode · 2021-09-10T16:47:47Z

maybe one more thing. If you change the text color, the Play and repeat button colors are not updated

@tibbi Please what steps did you follow to detect this? I am unable to reproduce it

tibbi · 2021-09-10T16:50:15Z

seems to occur only at paused timers, when the Repeat button is visible too. So basically toggle play/pause 2x, so you see both the repeat and Play button. Then go into the app settings, change the text color and those 2 buttons will still have the old color.

KryptKode · 2021-09-10T17:21:38Z

Still unable to reproduce after following the steps 😔

screencapture-1631294312406.mp4

tibbi · 2021-09-10T17:31:24Z

do not change the whole theme, just the text color

tibbi · 2021-09-12T09:43:36Z

app/src/main/kotlin/com/simplemobiletools/clock/services/TimerService.kt

+                val contextText = when {
+                    runningTimers.size > 1 -> getString(R.string.timer_multiple_notification_msg, runningTimers.size)
+                    firstTimer.label.isNotEmpty() -> getString(R.string.timer_single_notification_label_msg, firstTimer.label)
+                    else -> getString(R.string.timer_single_notification_msg, runningTimers.size)


The above timer_multiple_notification_msg has to be added as a Plural in the strings file so it can be properly translated in case it is 2 timers or 5, as it differs in some languages. I mean like https://github.com/SimpleMobileTools/Simple-Commons/blob/7c0a8d628ee23094e669a6169220b8da0fe9e649/commons/src/main/res/values/strings.xml#L165 . Add the "one" usecase too, then you can remove the timer_single_notification_msg string

tibbi · 2021-09-12T15:29:37Z

alright, looks like we are done now, thanks :)

KryptKode added 8 commits August 31, 2021 21:18

Setup adding/removing multiple timers

921ca92

Handle timer service notifications

9b421b3

Handle timer notifications

9df105a

timer UI improvements + bug fixes

037eac6

- add page indicator - add default timer based on saved prefs when the database is created - post scolling to the first timer when a new timer is added

make windowSoftInputMode adJustPan

ca4e5d9

- this ensures the textfield is always above the keyboard

cleanup, remove logs

570279b

fix: reset/delete button getting hidden after multiple updates

8d6b577

tibbi reviewed Sep 3, 2021

View reviewed changes

app/src/main/kotlin/com/simplemobiletools/clock/adapters/TimerAdapter.kt Outdated Show resolved Hide resolved

tibbi reviewed Sep 3, 2021

View reviewed changes

app/src/main/kotlin/com/simplemobiletools/clock/services/TimerService.kt Outdated Show resolved Hide resolved

KryptKode added 2 commits September 3, 2021 19:42

ref: change timer UI to use RecyclerView

2e78d67

- update commons library

Remove PagerIndicator and related files

bd05a41

Implement concise view for timer

e1357ec

- implement EditTimerDialog - adding a new timer would show the dialog - clicking on a timer item would show the dialog

KryptKode added 3 commits September 7, 2021 23:15

Implement action mode, select to delete

db3e0c9

Implement concise view for timer

dc3ddac

Handle deletion of timers when running

a214ef9

KryptKode force-pushed the feat/multiple-timers branch from 09cdd02 to ebbd257 Compare September 7, 2021 23:17

lets move the label closer to the time

4e5d7ca

KryptKode added 4 commits September 10, 2021 14:27

Fix timer notification not dismissing on delete

2a87d74

Fix play/pause button color

a1894ce

Merge remote-tracking branch 'origin/feat/multiple-timers' into feat/…

e7576ab

…multiple-timers

Merge branch 'SimpleMobileTools:master' into feat/multiple-timers

d9a72b8

Change edit_timer_initial_time left drawable color with theme

b98d9c9

Recreate adapter when text color changes so it updates correctly

eee6565

tibbi reviewed Sep 12, 2021

View reviewed changes

Add Plural strings

acab6a2

KryptKode requested a review from tibbi September 12, 2021 14:01

tibbi added 8 commits September 12, 2021 17:20

Update strings.xml

e1caf9b

Update strings.xml

f791f30

Update strings.xml

e2983e0

Update strings.xml

89f6ca1

Update strings.xml

b9bb9d8

Update strings.xml

8ef6440

Update strings.xml

80a7f89

Update strings.xml

3bf340d

tibbi merged commit 8432684 into SimpleMobileTools:master Sep 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/multiple timers #285

Feat/multiple timers #285

KryptKode commented Sep 2, 2021 •

edited

tibbi commented Sep 3, 2021

tibbi commented Sep 3, 2021

tibbi commented Sep 3, 2021

KryptKode commented Sep 3, 2021

tibbi commented Sep 3, 2021 •

edited

KryptKode commented Sep 3, 2021

tibbi commented Sep 3, 2021

KryptKode commented Sep 3, 2021

tibbi commented Sep 6, 2021 •

edited

tibbi commented Sep 6, 2021 •

edited

KryptKode commented Sep 7, 2021

KryptKode commented Sep 7, 2021

tibbi commented Sep 7, 2021

KryptKode commented Sep 8, 2021

tibbi commented Sep 10, 2021

KryptKode commented Sep 10, 2021

tibbi commented Sep 10, 2021

KryptKode commented Sep 10, 2021

tibbi commented Sep 10, 2021

KryptKode commented Sep 10, 2021

tibbi commented Sep 10, 2021

KryptKode commented Sep 10, 2021 •

edited

tibbi commented Sep 10, 2021

tibbi Sep 12, 2021

tibbi commented Sep 12, 2021

Feat/multiple timers #285

Feat/multiple timers #285

Conversation

KryptKode commented Sep 2, 2021 • edited

tibbi commented Sep 3, 2021

tibbi commented Sep 3, 2021

tibbi commented Sep 3, 2021

KryptKode commented Sep 3, 2021

tibbi commented Sep 3, 2021 • edited

KryptKode commented Sep 3, 2021

tibbi commented Sep 3, 2021

KryptKode commented Sep 3, 2021

tibbi commented Sep 6, 2021 • edited

tibbi commented Sep 6, 2021 • edited

KryptKode commented Sep 7, 2021

KryptKode commented Sep 7, 2021

tibbi commented Sep 7, 2021

KryptKode commented Sep 8, 2021

tibbi commented Sep 10, 2021

KryptKode commented Sep 10, 2021

tibbi commented Sep 10, 2021

KryptKode commented Sep 10, 2021

tibbi commented Sep 10, 2021

KryptKode commented Sep 10, 2021

tibbi commented Sep 10, 2021

KryptKode commented Sep 10, 2021 • edited

tibbi commented Sep 10, 2021

tibbi Sep 12, 2021

Choose a reason for hiding this comment

tibbi commented Sep 12, 2021

KryptKode commented Sep 2, 2021 •

edited

tibbi commented Sep 3, 2021 •

edited

tibbi commented Sep 6, 2021 •

edited

tibbi commented Sep 6, 2021 •

edited

KryptKode commented Sep 10, 2021 •

edited