Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names disspear in edit mode and contact details view when contact has company field #862

Closed
ph00lt0 opened this issue Aug 8, 2022 · 13 comments

Comments

@ph00lt0
Copy link

ph00lt0 commented Aug 8, 2022

Since (one of) the last updates names are not shown when opening a contact and when editing the contact they disappear completely. Quite a critical bug I would say.

@tibbi
Copy link
Member

tibbi commented Aug 8, 2022

send a screenshot of what you mean please

@ph00lt0
Copy link
Author

ph00lt0 commented Aug 8, 2022

As you can see the name row in the details does not appear.
Interestingly the name also doesn't start with 'I' but this is shown in the contact image.

In the list view the name and image appear correctly as well as in my default contacts app, which I had to enable again.

signal-2022-08-08-171452
signal-2022-08-08-171524

@ph00lt0
Copy link
Author

ph00lt0 commented Aug 8, 2022

Just tested a bit further it seems this only happens when the contact has a company field.

Edit: the letter in the image is also from the company name.

Edit2: I basically have a contact with almost all my contacts as I like to keep track of that and search on people by company so this is rather inconvenient.

@ph00lt0 ph00lt0 changed the title Names disspear in edit mode and contact details view Names disspear in edit mode and contact details view when contact has company field Aug 8, 2022
@tibbi
Copy link
Member

tibbi commented Aug 8, 2022

well, why would the contacts name show if it has no name? It is a company

@ph00lt0
Copy link
Author

ph00lt0 commented Aug 8, 2022

I don't think you understand it. It isn't a company. It is a contact who works at a company?!
The list shows it fine, so it's isn't consistent anyhow.
The contact field can be used in two ways:

  • Either only company name is filled (so it is a company contact (in that case you are right) and It would probably be best to show the name of the company on top.
  • Name and company are filled (as well as optionally a position) and this is a human profile which obviously should show the name of the person (like it does in the list) and name of the company they work at.

I think you read over the fact that this contact actually does have a first and last name stored. The app just doesn't show it, well any other contacts app does.

@tibbi
Copy link
Member

tibbi commented Aug 8, 2022

guess you have the contact stored multiple times and the issue is caused by duplicate contact merging. Just click on one of the bottom fields to edit another instance of the contact stored under your email, Phone or so.

@tibbi tibbi closed this as completed Aug 8, 2022
@ph00lt0
Copy link
Author

ph00lt0 commented Aug 8, 2022

@tibbi sorry but this isn't the case. Not sure why you are closing this bug report.

@ph00lt0
Copy link
Author

ph00lt0 commented Aug 8, 2022

I store my contacts solemnly in my DAV5x server and any other contacts app shows this without any issue. I can see on the server that the details are correct

@tibbi
Copy link
Member

tibbi commented Aug 8, 2022

I dont see any issue on the screenshots

@ph00lt0
Copy link
Author

ph00lt0 commented Aug 8, 2022

The fields are empty? the name does not appear? how is that not an issue? I am getting a bit frustrated here. Your app completely ignores the values stored in the contact, doesn't display them in either edit or view mode and overwrites them as empty on saving.

@tibbi
Copy link
Member

tibbi commented Aug 8, 2022

names are empty because it is an organization..

@ph00lt0
Copy link
Author

ph00lt0 commented Aug 8, 2022

no it isn't, I do not know how to make this more clear to you.
I think you are mistaken what the company field is for: namely the company the person works at! It's simply an attribute. It shouldn't that if you use this the person is out of a sudden not having a name.

@ph00lt0
Copy link
Author

ph00lt0 commented Aug 8, 2022

signal-2022-08-08-215537
signal-2022-08-08-215513

I hope you see the difference and the problem now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants