Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serious bug = Data loss: deleting contact actually removes all entries withe the same name #872

Closed
lfom opened this issue Aug 26, 2022 · 14 comments

Comments

@lfom
Copy link

lfom commented Aug 26, 2022

Hello!

Once again, thank you for providing the apps for free, the private contacts lists is a great idea. I wanna report a serious bug regarding contact management in Contacts 6.21.0 Pro. How to reproduce the problem:

  1. Create two contacts with the same name, for instance first name = A, last name = X (so it appears in the top of the list), one with only the phone number and the other with just an email
  2. Edit the second contact and add a phone number
  3. Delete the first one with only the phone number
  4. Result: both contacts are gone

This is a serious problem, I hope this can be fixed soon.

Regards

@tibbi
Copy link
Member

tibbi commented Aug 27, 2022

  1. are you deleting from the edit or view screen?

@lfom
Copy link
Author

lfom commented Aug 27, 2022

@tibbi I have just tested it here: the problem happens either if I delete the contact while it is selected in the list or viewing the contact details, but not when editing the contact that will be deleted (edit first, then delete).

By the way, there is also a bug that once the keyboard shown while editing an item, the top bar with the icons is moved upwards and gets somewhat hidden, it's required to hide the keyboard (or "go back" ) first in order to be able to save.

@tibbi
Copy link
Member

tibbi commented Aug 28, 2022

right, so that isnt a bug. Edit screen deletes just the specific contact instance, but View screen or the list view deletes them all

@tibbi tibbi closed this as completed Aug 28, 2022
@lfom
Copy link
Author

lfom commented Aug 28, 2022

@tibbi I am sorry, but this is not the expected behavior nor what the vast majority of other similar apps do: if a contact is selected (or active in the details view) and delete is used then only the selected (or active) item us supposed to be removed. There is no info anywhere that all items with the same name will be removed. Just to be clear, not even the option to merge contacts was enabled, so deleting all items with the same name is not the expected behavior at all.

@vepain
Copy link

vepain commented Nov 12, 2022

Hello!

I think this issue should be re-open.

I am sorry, but this is not the expected behavior
I agree with @lfom
At least, a warning message is necessary, but I think this issue should not be asked.

In fact, if you want to move a large amount of contact from A to B, you have to export A first then import to B.
And then, the idea is to remove the duplicated contact in A.

  1. you can't remove from the view with selecting from a filter just A, because of this behaviour
  2. if you want to remove one by one in A, even if you edit first, removing contact A remove the duplicated contact in B, while the merge option is not selected (perhaps because of contact uid?)

One solution can be:

  • if you select the merge option, then removing a contact (even in a filter view) can remove its clone in all the other places
  • if the merge option is false, then removing a contact from a filter view must not remove its clone in the other places.

Thank you for this app, I think this can be a great upgrade :)

@lfom
Copy link
Author

lfom commented Nov 12, 2022

Yes, this causes data loss and should be changed. There's no info anywhere that deleting the contact being viewed will also delete every other contact with the same name.

@tibbi
Copy link
Member

tibbi commented Nov 12, 2022

the fact that the contact will be deleted from all contact sources is written directly at the confirmation dialog.

@lfom
Copy link
Author

lfom commented Nov 12, 2022

@tibbi Deleting the current contact from all sources is not the problem. The problem is that all other contacts with the same name will also be removed from all sources, causing data loss. This can be reproduced using the steps in my previous post or the ones in @vepain post as well.

@vepain
Copy link

vepain commented Nov 13, 2022

the fact that the contact will be deleted from all contact sources is written directly at the confirmation dialog.

In french it is only written "Are you sure to delete the contact?"
Perhaps in english it is clearer.

@tibbi
Copy link
Member

tibbi commented Nov 13, 2022

the fact that the contact will be deleted from all contact sources is written directly at the confirmation dialog.

In french it is only written "Are you sure to delete the contact?" Perhaps in english it is clearer.

thats when you delete from the Edit screen, only 1 single contact is deleted. Multiple ones are deleted only at the View Details screen

@lfom
Copy link
Author

lfom commented Nov 13, 2022

@tibbi Sorry, but you still didn't get it... You do not have many contacts with the same first name, people you do not ask their last name, etc? For instance, I have three contacts named Tibor, with different phone numbers and addresses, they have the same name but they are different contacts. If I remove one of them from the contacts list, all of them are deleted, causing data loss. There is no info anywhere warning that this will happen! Of course, there is a warning that deleting a contact will remove it from the list, but there no info anywhere that all three contacts with the same named (Tibor) will be deleted from the app! Any user is expecting that only the contact being displayed will be deleted, but this action deletes all contacts with the same name as the one being deleted.

@vepain
Copy link

vepain commented Nov 13, 2022

thats when you delete from the Edit screen, only 1 single contact is deleted. Multiple ones are deleted only at the View Details screen

I tested all the delete cases, and I have the same result (duplicated contacts from different accounts are all deleted) and the same french warning message

@lfom
Copy link
Author

lfom commented Nov 13, 2022

Also, every other existing Contacts app (as well as any other app with items shown on a list that can be selected and deleted) only deletes the item that is being displayed. There is no reason at all to silently delete all items with th same name. This is not expected and not user friendly.

@lel-amri
Copy link

I'm agree with the idea that deleting all contacts with a related name isn't what I expect a contacts app to do (any app actually). When I want to delete an entry, I want only this entry to be deleted, not other entries that the application think are related. Deleting "related" entries is kind of evil actually :/
I hopefully backup my data, otherwise I'd have just lost the 5 "Anne" I have in my contact book (that I can distinguish thanks to the notes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants