Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn flashlight on at startup bug resolved #111

Merged
merged 3 commits into from Aug 20, 2020

Conversation

im-indrajeet
Copy link
Contributor

Turn flashlight on at startup setting is activate and after switching off flashlight user navigates away to other app and come back to this app again flashlight will be turned on. This regards to issue #71

Turn flashlight on at startup preferece is chosen and user navigates away to other app and coming back to this appthen flashlight will be turned on again. This regards to  issue SimpleMobileTools#71
@tibbi
Copy link
Member

tibbi commented May 25, 2020

fix some spacing around brackets and resolve the conflicts please

@im-indrajeet
Copy link
Contributor Author

fix some spacing around brackets and resolve the conflicts please

I resolved conflicts and fixed spacing around brackets

startActivity(Intent(applicationContext, SettingsActivity::class.java))
}

private fun launchAbout() {
val licenses = LICENSE_EVENT_BUS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is two lines with same variable name val licenses = LICENSE_EVENT_BUS and val licenses = LICENSE_OTTO. Line val licenses = LICENSE_EVENT_BUS was not here previously I don't know which one to remove so i removed this line please look at this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep EVENT_BUS only, that is apparently the newer one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep EVENT_BUS only, that is apparently the newer one

Done

@tibbi
Copy link
Member

tibbi commented May 25, 2020

will test it later, not working on the Flashlight right now. Should be ok. Thanks

@im-indrajeet
Copy link
Contributor Author

will test it later, not working on the Flashlight right now. Should be ok. Thanks

Ok thanks

@tibbi tibbi merged commit ba780f4 into SimpleMobileTools:master Aug 20, 2020
@tibbi
Copy link
Member

tibbi commented Aug 20, 2020

looks good, hope it wont break anything :) Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants